From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VtvaO-0006VD-GM
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 03:37:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VtvaI-00056K-VC
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 03:37:32 -0500
Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:53047)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VtvaI-00054n-Nx
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 03:37:26 -0500
Received: by mail-wg0-f47.google.com with SMTP id n12so2099257wgh.26
	for <qemu-devel@nongnu.org>; Fri, 20 Dec 2013 00:37:25 -0800 (PST)
Date: Fri, 20 Dec 2013 09:37:22 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131220083722.GC15789@stefanha-thinkpad.redhat.com>
References: <20131219124937.7976.97411.malonedeb@soybean.canonical.com>
	<20131219124937.7976.97411.malonedeb@soybean.canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20131219124937.7976.97411.malonedeb@soybean.canonical.com>
Subject: Re: [Qemu-devel] [Bug 1262650] [NEW] Latest git version fails to
 compile in	block/iscsi.o
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nigel Horne <1262650@bugs.launchpad.net>
Cc: qemu-devel@nongnu.org

On Thu, Dec 19, 2013 at 12:49:36PM -0000, Nigel Horne wrote:
> Public bug reported:
> 
> Git version f46e720a82ccdf1a521cf459448f3f96ed895d43 (and possibly
> b91f93243bbe36dc436a64a662a9bbfb2362534a) fail to build under Linux
> using gcc 4.8.1:
> 
> block/iscsi.c: In function ‘iscsi_co_readv’:
> block/iscsi.c:363:40: error: too many arguments to function ‘iscsi_read10_task’
>                                         iscsi_co_generic_cb, &iTask);

Thanks for reporting this bug.  The fix will soon be merged into
qemu.git, it's currently in my block subsystem tree:

commit 219c252193862898430e5dea5efb7447877aaa85
Author: Stefan Weil <sw@weilnetz.de>
Date:   Tue Dec 17 08:57:10 2013 +0100

    block/iscsi: Fix compilation for libiscsi 1.4.0 (API change)