From: Stefan Hajnoczi <stefanha@gmail.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>,
Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH v3 6/6] qcow2: Add full image preallocation option
Date: Fri, 20 Dec 2013 11:21:52 +0100 [thread overview]
Message-ID: <20131220102152.GG27021@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <4f5c56d2ebd81d5ae3333b4894eb785ab98cf2db.1387419339.git.hutao@cn.fujitsu.com>
On Thu, Dec 19, 2013 at 10:27:41AM +0800, Hu Tao wrote:
> -static int preallocate(BlockDriverState *bs)
> +static int preallocate(BlockDriverState *bs, enum prealloc_mode mode)
> {
> uint64_t nb_sectors;
> uint64_t offset;
> @@ -1395,9 +1395,19 @@ static int preallocate(BlockDriverState *bs)
> int ret;
> QCowL2Meta *meta;
>
> + assert(mode != PREALLOC_OFF);
> +
> nb_sectors = bdrv_getlength(bs) >> 9;
> offset = 0;
>
> + if (mode == PREALLOC_FULL) {
> + ret = bdrv_preallocate(bs->file, 0, bdrv_getlength(bs));
This doesn't make sense since it fails to factor in qcow2 metadata and
the file layout.
next prev parent reply other threads:[~2013-12-20 10:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 2:27 [Qemu-devel] [RFC PATCH v3 0/6] qemu-img: add preallocation=full Hu Tao
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 1/6] block: introduce prealloc_mode Hu Tao
2013-12-20 10:08 ` Stefan Hajnoczi
2013-12-20 12:36 ` Eric Blake
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 2/6] block: add BlockDriver.bdrv_preallocate Hu Tao
2013-12-20 10:10 ` Stefan Hajnoczi
2013-12-24 8:31 ` Hu Tao
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 3/6] block/raw-posix: implement bdrv_preallocate Hu Tao
2013-12-20 10:14 ` Stefan Hajnoczi
2013-12-23 1:45 ` Hu Tao
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 4/6] raw-posix: Add full image preallocation option Hu Tao
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 5/6] qcow2: implement bdrv_preallocate Hu Tao
2013-12-20 10:19 ` Stefan Hajnoczi
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 6/6] qcow2: Add full image preallocation option Hu Tao
2013-12-20 10:21 ` Stefan Hajnoczi [this message]
2013-12-20 10:30 ` [Qemu-devel] [RFC PATCH v3 0/6] qemu-img: add preallocation=full Stefan Hajnoczi
2013-12-20 12:54 ` Eric Blake
2013-12-23 1:59 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220102152.GG27021@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).