From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu029-0007VE-Ie for qemu-devel@nongnu.org; Fri, 20 Dec 2013 08:22:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vu020-0005iE-Hz for qemu-devel@nongnu.org; Fri, 20 Dec 2013 08:22:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu020-0005i0-Cn for qemu-devel@nongnu.org; Fri, 20 Dec 2013 08:22:20 -0500 Date: Fri, 20 Dec 2013 14:22:11 +0100 From: Igor Mammedov Message-ID: <20131220142211.1e2ac64b@nial.usersys.redhat.com> In-Reply-To: <52B43C64.6080408@suse.de> References: <1387537713-18619-1-git-send-email-imammedo@redhat.com> <52B43C64.6080408@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC] test: QOM interface casting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: Peter Maydell , Peter Crosthwaite , Eduardo Habkost , qemu-devel@nongnu.org, armbru@redhat.com, anthony@codemonkey.ws, pbonzini@redhat.com On Fri, 20 Dec 2013 13:47:32 +0100 Andreas F=E4rber wrote: > Hi, >=20 > Am 20.12.2013 12:08, schrieb Igor Mammedov: > > --- > > tests/Makefile | 3 + > > tests/check-qom-interface.c | 102 +++++++++++++++++++++++++++++++++++= ++++++++ > > 2 files changed, 105 insertions(+), 0 deletions(-) > > create mode 100644 tests/check-qom-interface.c >=20 > Apart from the style issues and typos that the two Peter's have pointed > out, I'd like to point out that this is missing Signed-off-by and commit > message. In particular, is this a test that should be committed > alongside the interface cast fixes or anything else that I have queued? > Or just to improve overall test coverage? Either way I'm in favor of > having them. Since interfaces are not widely used it's easy to break them, this adds regression testing. It could go along with fixes you've queued. >=20 > Concerning PMM's comment, don't we already have a qdev properties unit > test from Eduardo where we might share QOM dependencies via some > Makefile variable? Grouping the check-* tests also makes sense to me > than just adding at the bottom. >=20 > Anything in particular that you'd like comments on, this being an RFC? Peters's and your comments are applied, I'll respin it as patch, thanks for reviewing. > Regards, > Andreas >=20