From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu2CJ-0007hy-M6 for qemu-devel@nongnu.org; Fri, 20 Dec 2013 10:41:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vu2CF-0006v9-41 for qemu-devel@nongnu.org; Fri, 20 Dec 2013 10:41:07 -0500 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:52740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vu2CE-0006uy-Sr for qemu-devel@nongnu.org; Fri, 20 Dec 2013 10:41:03 -0500 Received: by mail-wi0-f172.google.com with SMTP id en1so8560873wid.11 for ; Fri, 20 Dec 2013 07:41:02 -0800 (PST) Date: Fri, 20 Dec 2013 16:40:56 +0100 From: Stefan Hajnoczi Message-ID: <20131220154056.GA13897@stefanha-thinkpad.redhat.com> References: <1387176333-30183-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387176333-30183-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 0/7] block: allow commit active as top List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Dec 16, 2013 at 02:45:26PM +0800, Fam Zheng wrote: > Previously live commit of active block device is not supported, this series > implements it and updates corresponding qemu-iotests cases. > > This series is based on BlockJobType enum QAPI series. > > v7: Fix "Since 1.8" to "Since 2.0". > Rebase patch 05 to master. > > v6: Address comments from Stefan: > > [04/06] commit: support commit active layer > Fix wording. > [05/06] qemu-iotests: update test cases for commit active > Drop is_active. > > Experimental for reviewers: the side by side diff against previous series: > > http://goo.gl/vgN6mc > > v5: Address comments from Eric and Paolo: > Add mirror_start_job and front end wrapper. [Paolo] > Base on BlockJobType enum in QAPI. [Eric] > Drop "common" sync mode. [Eric] > > v4: Rewrite to reuse block/mirror.c. > When committing the active layer, the job is internally a mirror job with > type name faked to "commit". > When the job completes, the BDSes are swapped, so the base image become > active and [top, base) dropped. > > > Fam Zheng (7): > blkdebug: Use QLIST_FOREACH_SAFE to resume IO > mirror: Don't close target > mirror: Move base to MirrorBlockJob > block: Add commit_active_start() > commit: Support commit active layer > qemu-iotests: Update test cases for commit active > commit: Remove unused check > > block/blkdebug.c | 8 ++--- > block/commit.c | 8 +---- > block/mirror.c | 78 +++++++++++++++++++++++++++++++++++++++-------- > blockdev.c | 9 ++++-- > include/block/block_int.h | 22 +++++++++++-- > qapi-schema.json | 5 +-- > tests/qemu-iotests/040 | 74 +++++++++++++++++++------------------------- > 7 files changed, 131 insertions(+), 73 deletions(-) > > -- > 1.8.5.1 > > Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan