From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scsi-disk: add non-zero MAX UNMAP LBA COUNT to block limits VPD page
Date: Sat, 21 Dec 2013 09:40:56 +0530 [thread overview]
Message-ID: <20131221041056.GA2780@in.ibm.com> (raw)
In-Reply-To: <1387551488-6824-1-git-send-email-pbonzini@redhat.com>
On Fri, Dec 20, 2013 at 03:58:08PM +0100, Paolo Bonzini wrote:
> Linux prefers WRITE SAME to UNMAP if the count is zero, and WRITE
> SAME does not discard anything unless the device can guarantee that
> the resulting block is zero.
>
> This fixes thin provisioning on glusterfs.
I don't see discard requests reaching GlusterFS even after this patch.
bdrv_co_discard or bdrv_aio_discard isn't getting called for the gluster
drive.
Regards,
Bharata.
prev parent reply other threads:[~2013-12-21 4:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 14:58 [Qemu-devel] [PATCH] scsi-disk: add non-zero MAX UNMAP LBA COUNT to block limits VPD page Paolo Bonzini
2013-12-21 4:10 ` Bharata B Rao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131221041056.GA2780@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).