From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40146)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VuOZk-00005V-3Q
	for qemu-devel@nongnu.org; Sat, 21 Dec 2013 10:34:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VuOZb-00037q-8G
	for qemu-devel@nongnu.org; Sat, 21 Dec 2013 10:34:48 -0500
Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:46178)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1VuOZb-00033t-2Z
	for qemu-devel@nongnu.org; Sat, 21 Dec 2013 10:34:39 -0500
Date: Sat, 21 Dec 2013 16:34:19 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20131221153419.GA9208@ohm.rr44.fr>
References: <1387203165-5553-1-git-send-email-james.hogan@imgtec.com>
	<1387203165-5553-6-git-send-email-james.hogan@imgtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1387203165-5553-6-git-send-email-james.hogan@imgtec.com>
Subject: Re: [Qemu-devel] [PATCH v2 05/10] kvm: Set sigmask length to 16 for
	MIPS targets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Gleb Natapov <gleb@redhat.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Sanjay Lal <sanjayl@kymasys.com>

On Mon, Dec 16, 2013 at 02:12:40PM +0000, James Hogan wrote:
> From: Sanjay Lal <sanjayl@kymasys.com>
> 
> MIPS/Linux is unusual in having 128 signals rather than just 64 like
> most other architectures. This means its sigmask is 16 bytes instead of
> 8, so correct kvm_set_signal_mask to pass the correct sigmask->len to
> KVM_SET_SIGNAL_MASK.
> 
> Signed-off-by: Sanjay Lal <sanjayl@kymasys.com>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Gleb Natapov <gleb@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Changes in v2:
>  - Expand commit message
>  - Reword comment
> ---
>  kvm-all.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index 4478969..c831326 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -2044,7 +2044,12 @@ int kvm_set_signal_mask(CPUState *cpu, const sigset_t *sigset)
>  
>      sigmask = g_malloc(sizeof(*sigmask) + sizeof(*sigset));
>  
> +#ifdef TARGET_MIPS
> +    /* MIPS has 128 signals */
> +    sigmask->len = 16;
> +#else
>      sigmask->len = 8;
> +#endif
>      memcpy(sigmask->sigset, sigset, sizeof(*sigset));
>      r = kvm_vcpu_ioctl(cpu, KVM_SET_SIGNAL_MASK, sigmask);
>      g_free(sigmask);

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net