qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: pbonzini@redhat.com, agraf@suse.de, mst@redhat.com,
	qemu-devel@nongnu.org, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] Add DSDT node for AppleSMC
Date: Sun, 22 Dec 2013 22:19:52 -0500	[thread overview]
Message-ID: <20131223031935.GA27758@crash.ini.cmu.edu> (raw)
In-Reply-To: <52B765CC.2010800@redhat.com>

On Sun, Dec 22, 2013 at 11:21:00PM +0100, Laszlo Ersek wrote:
> > 	2. Use "IRQNoFlags() { 5 }" with the SMC (or any other
> > 	   number that isn't already allocated.
> 
> I don't think there's anything left free:
>...
> 
> I guess the "by the book" solution would be to really stop the FDC from
> being emulated when the AppleSMC is present, but I mention that idea
> only because I like to waste bandwidth.
> 
> Option 1 ("Do nothing") sounds appropriate to me.

So making the FDC optional (or at least allowing it to be left out)
sounds like it could be a fun project I could play with later (unless
anyone else beats me to it), but it would be nice if it didn't end up
a hard precondition for getting the SMC ACPI patch accepted :)

Once we can turn off the FDC, we can make it and the SMC mutually
exclusive and/or throw an error if both are enabled.

In reality (and Alex, please correct me if I'm wrong), the emulated
SMC will never generate an INT#6, unlike the real hardware chip. The
emulated SMC is just there to say "Yeah, boss, sure, let me get right
on that for you!" to OS X, to calm it down and make it think everything
is right with its little universe :) The real chip might trigger an
interrupt if something's getting too hot, or a fan stopped spinning
when it shouldn't have, but that's never going to happen on a VM guest.

OS X doesn't even assume the presence of an FDC, and any guest OS
which expects an FDC will never get unexpected conflicting interrupts
from the emulated SMC, should the latter be enabled, accidentally or
not. So in practice the risk for any trouble should be about zero...

Thanks for helping me think this stuff through !
--Gabriel

  reply	other threads:[~2013-12-23  3:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20 15:54 [Qemu-devel] [PATCH] Add DSDT node for AppleSMC Gabriel L. Somlo
2013-12-20 16:39 ` Alexander Graf
2013-12-20 20:52   ` [Qemu-devel] [PATCH v2] " Gabriel L. Somlo
2013-12-20 21:38     ` Igor Mammedov
2013-12-22 15:34       ` Gabriel L. Somlo
2013-12-22 11:07     ` Michael S. Tsirkin
2013-12-22 15:34       ` [Qemu-devel] [PATCH v3] " Gabriel L. Somlo
2013-12-22 15:58         ` Laszlo Ersek
2013-12-22 17:14           ` Gabriel L. Somlo
2013-12-22 22:21             ` Laszlo Ersek
2013-12-23  3:19               ` Gabriel L. Somlo [this message]
2013-12-25 19:11                 ` Alexander Graf
2013-12-25 19:20                   ` Michael S. Tsirkin
2013-12-25 21:33                     ` Alexander Graf
2013-12-25 21:54                       ` Michael S. Tsirkin
2013-12-25 14:12         ` Michael S. Tsirkin
2014-01-13 17:53           ` [Qemu-devel] [PATCH v4] " Gabriel L. Somlo
2014-01-13 19:17             ` [Qemu-devel] [PATCH] ACPI: AppleSMC _STA method should return 32bit value Gabriel L. Somlo
2014-01-13 20:27               ` [Qemu-devel] [PATCH v2] ACPI: Fix AppleSMC _STA size Gabriel L. Somlo
2014-01-14 10:46                 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131223031935.GA27758@crash.ini.cmu.edu \
    --to=gsomlo@gmail.com \
    --cc=agraf@suse.de \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).