From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vv43r-000838-4P for qemu-devel@nongnu.org; Mon, 23 Dec 2013 06:52:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vv43n-0003kM-1c for qemu-devel@nongnu.org; Mon, 23 Dec 2013 06:52:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vv43m-0003jT-OP for qemu-devel@nongnu.org; Mon, 23 Dec 2013 06:52:34 -0500 Date: Mon, 23 Dec 2013 13:56:22 +0200 From: "Michael S. Tsirkin" Message-ID: <20131223115622.GA6490@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] target-arm: fix build on fedora List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , John Rigby , lersek@redhat.com, Alexander Graf , Richard Henderson commit 5ce4f35781028ce1aee3341e6002f925fdc7aaf3 "target-arm: A64: add set_pc cpu method" introduces an array aarch64_cpus which is zero size if this code is built without CONFIG_USER_ONLY. In particular an attempt to iterate over this array produces a warning: CC aarch64-softmmu/target-arm/cpu64.o /scm/qemu/target-arm/cpu64.c: In function =E2=80=98aarch64_cpu_register_t= ypes=E2=80=99: /scm/qemu/target-arm/cpu64.c:124:5: error: comparison of unsigned expression < 0 is always false [-Werror=3Dtype-limits] for (i =3D 0; i < ARRAY_SIZE(aarch64_cpus); i++) { ^ cc1: all warnings being treated as errors This is the result of ARRAY_SIZE being an unsigned type, causing i to be promoted to unsigned int as well. As zero size arrays are a gcc extension, it seems cleanest to add a dummy element with NULL name, and test for it during registration. Cc: Alexander Graf Cc: Peter Maydell Cc: Richard Henderson Signed-off-by: Michael S. Tsirkin --- I have queued this in my tree since it prevents me from being able to build and test properly. Pls review and ack. target-arm/cpu64.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 04ce879..2efe189 100644 --- a/target-arm/cpu64.c +++ b/target-arm/cpu64.c @@ -58,6 +58,7 @@ static const ARMCPUInfo aarch64_cpus[] =3D { #ifdef CONFIG_USER_ONLY { .name =3D "any", .initfn =3D aarch64_any_initfn }, #endif + { .name =3D NULL } }; =20 static void aarch64_cpu_initfn(Object *obj) @@ -100,6 +101,10 @@ static void aarch64_cpu_register(const ARMCPUInfo *i= nfo) .class_init =3D info->class_init, }; =20 + if (!info->name) { + return; + } + type_info.name =3D g_strdup_printf("%s-" TYPE_ARM_CPU, info->name); type_register(&type_info); g_free((void *)type_info.name); --=20 MST