From: "Michael S. Tsirkin" <mst@redhat.com>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/3] acpi unit-test: compare resulting aml vs expected aml
Date: Mon, 23 Dec 2013 14:02:15 +0200 [thread overview]
Message-ID: <20131223120215.GA6492@redhat.com> (raw)
In-Reply-To: <1387793606-4761-1-git-send-email-marcel.a@redhat.com>
On Mon, Dec 23, 2013 at 12:13:23PM +0200, Marcel Apfelbaum wrote:
> The test:
> - runs only if iasl is installed on the host machine.
> - the test plan:
> 1. Dumps the ACPI tables as AML on the disk.
> 2. Runs iasl to disassembly the tables into ASL files.
> 3. Runs iasl to disassembly the offline AML files.
> 3. Compares them with expected offline ASL files.
> - the test runs for both default machine and q35.
Looks good to me overall.
One thing I'd like to ask is that you add a script to
run after ACPI tables are updated.
It could update both pre-generated hex files and the
expected files.
> - in case the test fails, it can be easily tweaked to
> show the differences between the ASL files and
> understand the issue.
How exactly does it need to be tweaked?
> Patches:
> 1/3 - expected aml files
> 2/3 - creates links for the expected files
> if the build directory is not current
> 3/3 - the test
> Marcel Apfelbaum (3):
> acpi unit-test: add test files
> configure: added acpi unit-test files
> acpi unit-test: compare DSDT and SSDT tables against expected values
>
> configure | 4 +
> tests/acpi-test-data/pc/APIC | Bin 0 -> 120 bytes
> tests/acpi-test-data/pc/DSDT | Bin 0 -> 4407 bytes
> tests/acpi-test-data/pc/FACP | Bin 0 -> 116 bytes
> tests/acpi-test-data/pc/FACS | Bin 0 -> 64 bytes
> tests/acpi-test-data/pc/HPET | Bin 0 -> 56 bytes
> tests/acpi-test-data/pc/SSDT | Bin 0 -> 2104 bytes
> tests/acpi-test-data/q35/APIC | Bin 0 -> 120 bytes
> tests/acpi-test-data/q35/DSDT | Bin 0 -> 7344 bytes
> tests/acpi-test-data/q35/FACP | Bin 0 -> 116 bytes
> tests/acpi-test-data/q35/FACS | Bin 0 -> 64 bytes
> tests/acpi-test-data/q35/HPET | Bin 0 -> 56 bytes
> tests/acpi-test-data/q35/MCFG | Bin 0 -> 60 bytes
> tests/acpi-test-data/q35/SSDT | Bin 0 -> 2104 bytes
> tests/acpi-test.c | 257 ++++++++++++++++++++++++++++++++++++++----
> 15 files changed, 240 insertions(+), 21 deletions(-)
> create mode 100644 tests/acpi-test-data/pc/APIC
> create mode 100644 tests/acpi-test-data/pc/DSDT
> create mode 100644 tests/acpi-test-data/pc/FACP
> create mode 100644 tests/acpi-test-data/pc/FACS
> create mode 100644 tests/acpi-test-data/pc/HPET
> create mode 100644 tests/acpi-test-data/pc/SSDT
> create mode 100644 tests/acpi-test-data/q35/APIC
> create mode 100644 tests/acpi-test-data/q35/DSDT
> create mode 100644 tests/acpi-test-data/q35/FACP
> create mode 100644 tests/acpi-test-data/q35/FACS
> create mode 100644 tests/acpi-test-data/q35/HPET
> create mode 100644 tests/acpi-test-data/q35/MCFG
> create mode 100644 tests/acpi-test-data/q35/SSDT
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2013-12-23 11:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 10:13 [Qemu-devel] [PATCH v2 0/3] acpi unit-test: compare resulting aml vs expected aml Marcel Apfelbaum
2013-12-23 10:13 ` [Qemu-devel] [PATCH v2 1/3] acpi unit-test: add test files Marcel Apfelbaum
2013-12-23 10:13 ` [Qemu-devel] [PATCH v2 2/3] configure: added acpi unit-test files Marcel Apfelbaum
2013-12-23 10:13 ` [Qemu-devel] [PATCH v2 3/3] acpi unit-test: compare DSDT and SSDT tables against expected values Marcel Apfelbaum
2013-12-23 12:06 ` Michael S. Tsirkin
2013-12-23 12:22 ` Marcel Apfelbaum
2013-12-23 15:26 ` Michael S. Tsirkin
2013-12-23 12:02 ` Michael S. Tsirkin [this message]
2013-12-23 12:18 ` [Qemu-devel] [PATCH v2 0/3] acpi unit-test: compare resulting aml vs expected aml Marcel Apfelbaum
2013-12-23 14:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131223120215.GA6492@redhat.com \
--to=mst@redhat.com \
--cc=marcel.a@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).