From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57672)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kirill.shutemov@linux.intel.com>) id 1Vv4WR-0007GK-Fi
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 07:22:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kirill.shutemov@linux.intel.com>) id 1Vv4WH-0003Kv-3I
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 07:22:11 -0500
Received: from mga09.intel.com ([134.134.136.24]:48862)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kirill.shutemov@linux.intel.com>) id 1Vv4WG-0003KE-Tv
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 07:22:01 -0500
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
In-Reply-To: <87ppp6b6yo.fsf@linux.vnet.ibm.com>
References: <1385726178-10201-1-git-send-email-kirill.shutemov@linux.intel.com>
	<20131209102517.33F4EE0090@blue.fi.intel.com>
	<87ppp6b6yo.fsf@linux.vnet.ibm.com>
Content-Transfer-Encoding: 7bit
Message-Id: <20131223122138.931E2E0090@blue.fi.intel.com>
Date: Mon, 23 Dec 2013 14:21:38 +0200 (EET)
Subject: Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN
	handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, aliguori@amazon.com

Aneesh Kumar K.V wrote:
> "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:
> 
> > Kirill A. Shutemov wrote:
> >> Currently we have few issues with P9_STATS_GEN:
> >> 
> >>  - We don't try to read st_gen anything except files or directories, but
> >>    still set P9_STATS_GEN bit in st_result_mask. It may mislead client:
> >>    we present garbage as valid st_gen.
> >> 
> >>  - If we failed to get valid st_gen with ENOTTY, we ignore error, but
> >>    still set P9_STATS_GEN bit in st_result_mask.
> >> 
> >>  - If we failed to get valid st_gen with any other errno, we fail
> >>    getattr altogether. It's excessive: we block valid client use-cases,
> >>    like chdir(2) to non-readable directory with execution bit set.
> >> 
> >> The patch fixes these issues and cleanup code a bit.
> >> 
> >> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> >> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
> >> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> >
> > Ping?
> >
> 
> I am hoping that this will go to upstream directly without me doing a
> pull request ? Anthony, let me know if this need anything to be done
> from my side

So? Nobody cares?

-- 
 Kirill A. Shutemov