Re: [Qemu-devel] [PATCH v2 0/3] acpi unit-test: compare resulting aml vs expected aml

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Dec 23, 2013 at 02:18:47PM +0200, Marcel Apfelbaum wrote:
> On Mon, 2013-12-23 at 14:02 +0200, Michael S. Tsirkin wrote:
> > On Mon, Dec 23, 2013 at 12:13:23PM +0200, Marcel Apfelbaum wrote:
> > > The test:
> > >  - runs only if iasl is installed on the host machine.
> > >  - the test plan:
> > >    1. Dumps the ACPI tables as AML on the disk.
> > >    2. Runs iasl to disassembly the tables into ASL files.
> > >    3. Runs iasl to disassembly the offline AML files.
> > >    3. Compares them with expected offline ASL files.
> > >  - the test runs for both default machine and q35.
> > 
> > Looks good to me overall.
> > One thing I'd like to ask is that you add a script to
> > run after ACPI tables are updated.
> > It could update both pre-generated hex files and the
> > expected files.
> I don't think that I understand, what is the script's
> purpose?

Update aml in git after we make source changes.

> > 
> > >  - in case the test fails, it can be easily tweaked to
> > >    show the differences between the ASL files and
> > >    understand the issue.
> > 
> > How exactly does it need to be tweaked?
> Instead of the assert that is failing when the asl files
> are not the same, one could print them to console.
> Another thing that can be done is to print to
> console the  dumped asl file names and manually do the diff.
> 
> Thanks,
> Marcel

Can this be done automatically e.g. before the assert?
Alternatively add a comment so people know what to do
and where.

> > 
> > > Patches:
> > >  1/3 - expected aml files
> > >  2/3 - creates links for the expected files
> > >        if the build directory is not current
> > >  3/3 - the test
> > > Marcel Apfelbaum (3):
> > >   acpi unit-test: add test files
> > >   configure: added acpi unit-test files
> > >   acpi unit-test: compare DSDT and SSDT tables against expected values
> > > 
> > >  configure                     |   4 +
> > >  tests/acpi-test-data/pc/APIC  | Bin 0 -> 120 bytes
> > >  tests/acpi-test-data/pc/DSDT  | Bin 0 -> 4407 bytes
> > >  tests/acpi-test-data/pc/FACP  | Bin 0 -> 116 bytes
> > >  tests/acpi-test-data/pc/FACS  | Bin 0 -> 64 bytes
> > >  tests/acpi-test-data/pc/HPET  | Bin 0 -> 56 bytes
> > >  tests/acpi-test-data/pc/SSDT  | Bin 0 -> 2104 bytes
> > >  tests/acpi-test-data/q35/APIC | Bin 0 -> 120 bytes
> > >  tests/acpi-test-data/q35/DSDT | Bin 0 -> 7344 bytes
> > >  tests/acpi-test-data/q35/FACP | Bin 0 -> 116 bytes
> > >  tests/acpi-test-data/q35/FACS | Bin 0 -> 64 bytes
> > >  tests/acpi-test-data/q35/HPET | Bin 0 -> 56 bytes
> > >  tests/acpi-test-data/q35/MCFG | Bin 0 -> 60 bytes
> > >  tests/acpi-test-data/q35/SSDT | Bin 0 -> 2104 bytes
> > >  tests/acpi-test.c             | 257 ++++++++++++++++++++++++++++++++++++++----
> > >  15 files changed, 240 insertions(+), 21 deletions(-)
> > >  create mode 100644 tests/acpi-test-data/pc/APIC
> > >  create mode 100644 tests/acpi-test-data/pc/DSDT
> > >  create mode 100644 tests/acpi-test-data/pc/FACP
> > >  create mode 100644 tests/acpi-test-data/pc/FACS
> > >  create mode 100644 tests/acpi-test-data/pc/HPET
> > >  create mode 100644 tests/acpi-test-data/pc/SSDT
> > >  create mode 100644 tests/acpi-test-data/q35/APIC
> > >  create mode 100644 tests/acpi-test-data/q35/DSDT
> > >  create mode 100644 tests/acpi-test-data/q35/FACP
> > >  create mode 100644 tests/acpi-test-data/q35/FACS
> > >  create mode 100644 tests/acpi-test-data/q35/HPET
> > >  create mode 100644 tests/acpi-test-data/q35/MCFG
> > >  create mode 100644 tests/acpi-test-data/q35/SSDT
> > > 
> > > -- 
> > > 1.8.3.1
> 
>