From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51438)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VvpI8-00079x-Ov
	for qemu-devel@nongnu.org; Wed, 25 Dec 2013 09:18:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VvpI2-0004Xw-IU
	for qemu-devel@nongnu.org; Wed, 25 Dec 2013 09:18:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23183)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VvpI2-0004Xq-Ag
	for qemu-devel@nongnu.org; Wed, 25 Dec 2013 09:18:26 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBPEIPDW021798
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 25 Dec 2013 09:18:25 -0500
Date: Wed, 25 Dec 2013 16:22:22 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131225142222.GC32493@redhat.com>
References: <1387968616-3629-1-git-send-email-marcel.a@redhat.com>
	<1387968616-3629-2-git-send-email-marcel.a@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1387968616-3629-2-git-send-email-marcel.a@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] configure: add CONFIG_IASL to
 config-host.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Dec 25, 2013 at 12:50:15PM +0200, Marcel Apfelbaum wrote:
> Acpi unit-tests will extract the iasl executable
> from CONFIG_IASL define.
> 
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
>  scripts/create_config | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/create_config b/scripts/create_config
> index b1adbf5..0478315 100755
> --- a/scripts/create_config
> +++ b/scripts/create_config
> @@ -26,6 +26,10 @@ case $line in
>      # save for the next definitions
>      prefix=${line#*=}
>      ;;
> + IASL=*) # iasl executable
> +    value=${line#*=}
> +    echo "#define CONFIG_IASL \"$value\""
> +    ;;

This won't work correctly if IASL includes any
special characters like \ or '.
It's a good idea to use preprocessor's # operator,
that escapes them properly.
We have a bunch of macros like this all over the place, short term
you can introduce
#define CONFIG_STRINGIFY(x) #x
longer term we really want QEMU_STRINGIFY.

>   CONFIG_AUDIO_DRIVERS=*)
>      drivers=${line#*=}
>      echo "#define CONFIG_AUDIO_DRIVERS \\"
> -- 
> 1.8.3.1