From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvqAc-0007j5-1X for qemu-devel@nongnu.org; Wed, 25 Dec 2013 10:14:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvqAX-0001RI-62 for qemu-devel@nongnu.org; Wed, 25 Dec 2013 10:14:49 -0500 Date: Wed, 25 Dec 2013 17:18:34 +0200 From: "Michael S. Tsirkin" Message-ID: <20131225151834.GA20075@redhat.com> References: <1387723882-30633-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387723882-30633-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH] virtio: Fix return value for dummy function vhost_net_virtqueue_pending List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Sun, Dec 22, 2013 at 03:51:22PM +0100, Stefan Weil wrote: > cgcc complains that -ENOSYS is not a good value for 'bool'. > > A dummy virtio will never have pending queue entries, so let us return > false. > > Signed-off-by: Stefan Weil Applied, thanks. > --- > > Could we also use g_assert_not_reached or hw_error in those dummy functions? > > Regards > Stefan I'd go for g_assert_not_reached normally - it's an internal bug if this is called since init stub fails. Or leave it as is - it's an unusual configuration. > hw/net/vhost_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > index 006576d..854997d 100644 > --- a/hw/net/vhost_net.c > +++ b/hw/net/vhost_net.c > @@ -321,7 +321,7 @@ void vhost_net_ack_features(struct vhost_net *net, unsigned features) > > bool vhost_net_virtqueue_pending(VHostNetState *net, int idx) > { > - return -ENOSYS; > + return false; > } > > void vhost_net_virtqueue_mask(VHostNetState *net, VirtIODevice *dev, > -- > 1.7.10.4