From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44403)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Vw8V9-0004ED-T1
	for qemu-devel@nongnu.org; Thu, 26 Dec 2013 05:49:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Vw8V4-0002km-IX
	for qemu-devel@nongnu.org; Thu, 26 Dec 2013 05:49:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51591)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Vw8V4-0002ki-9C
	for qemu-devel@nongnu.org; Thu, 26 Dec 2013 05:49:10 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBQAn9Fj016522
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 26 Dec 2013 05:49:09 -0500
Date: Thu, 26 Dec 2013 12:53:06 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131226105306.GB22584@redhat.com>
References: <1388054651-13764-1-git-send-email-marcel.a@redhat.com>
	<1388054651-13764-2-git-send-email-marcel.a@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1388054651-13764-2-git-send-email-marcel.a@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] acpi unit-test: added script to
 rebuild the expected aml files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel.a@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Dec 26, 2013 at 12:44:10PM +0200, Marcel Apfelbaum wrote:
> Acpi unit-test will fail every time the acpi tables change.
> This script rebuilds the expected aml files, so the test
> will pass. It also validates the modifications.
> 
> Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
> ---
>  tests/acpi-test-data/rebuild-expected-aml.sh | 36 ++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh
> 
> diff --git a/tests/acpi-test-data/rebuild-expected-aml.sh b/tests/acpi-test-data/rebuild-expected-aml.sh
> new file mode 100755
> index 0000000..8039718
> --- /dev/null
> +++ b/tests/acpi-test-data/rebuild-expected-aml.sh
> @@ -0,0 +1,36 @@
> +#! /bin/bash
> +
> +#
> +# Rebuild expected AML files for acpi unit-test 
> +#
> +# Copyright (c) 2013 Red Hat Inc.
> +#
> +# Authors:
> +#  Marcel Apfelbaum <marcel.a@redhat.com>
> +#
> +# This work is licensed under the terms of the GNU GPLv2.
> +# See the COPYING.LIB file in the top-level directory.
> +
> +qemu=
> +
> +if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then
> +    qemu="x86_64-softmmu/qemu-system-x86_64"
> +elif [ -e i386-softmmu/qemu-system-i386 ]; then
> +    qemu="i386-softmmu/qemu-system-i386"
> +else
> +    echo "Qemu executable qemu-system-x86_64 or qemu-system-i386 is required!"

maybe add "run make to build the executable"

> +    echo "Run this script from the build directory."
> +    exit -1;
> +fi
> +
> +if [ ! -e "tests/acpi-test" ]; then
> +    echo "Test: acpi-test is required! Run make check before this script."
> +    echo "Run this script from the build directory."
> +    exit -1;

you want exit 1 or some other positive value.

> +fi
> +
> +ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/acpi-test
> +
> +echo "The files were rebuild and can be added to git."

rebuilt

> +echo "However, if new files were created, please copy them manually" \
> +     "to tests/acpi-test-data/pc/ or tests/acpi-test-data/q35/ ."
> -- 
> 1.8.3.1