From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwAHB-0003n1-Ey for qemu-devel@nongnu.org; Thu, 26 Dec 2013 07:43:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VwAH6-0000ZO-3v for qemu-devel@nongnu.org; Thu, 26 Dec 2013 07:42:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwAH5-0000ZJ-Rt for qemu-devel@nongnu.org; Thu, 26 Dec 2013 07:42:52 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBQCgpBj022633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Dec 2013 07:42:51 -0500 Date: Thu, 26 Dec 2013 14:46:43 +0200 From: "Michael S. Tsirkin" Message-ID: <20131226124643.GA26225@redhat.com> References: <1388060390-16447-1-git-send-email-marcel.a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1388060390-16447-1-git-send-email-marcel.a@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files functionality List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: qemu-devel@nongnu.org On Thu, Dec 26, 2013 at 02:19:48PM +0200, Marcel Apfelbaum wrote: > Acpi unit-test will fail every time the acpi tables change. > > The series adds a script that rebuilds the expected aml files, so the test > will pass. It also validates the modifications. > > The acpi unit test will rebuild the aml tables if TEST_ACPI_REBUILD_AML > environment variable is set. OK I had to fix some trailing whitespace, otherwise looks good. I applied it all, pls check the pci branch. > v1 -> v2: > Addressed Michael S. Tsirkin's comments: > - added TEST_ prefix to the environment variable > - some rephrases > > Marcel Apfelbaum (2): > acpi unit-test: added script to rebuild the expected aml files > acpi unit-test: hook to rebuild expected aml files > > tests/acpi-test-data/rebuild-expected-aml.sh | 36 ++++++++++++++++++++++++++++ > tests/acpi-test.c | 30 +++++++++++++++++++---- > 2 files changed, 61 insertions(+), 5 deletions(-) > create mode 100755 tests/acpi-test-data/rebuild-expected-aml.sh > > -- > 1.8.3.1