From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48616)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VxQtJ-0000x1-G7
	for qemu-devel@nongnu.org; Sun, 29 Dec 2013 19:39:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VxQtE-0006mi-GX
	for qemu-devel@nongnu.org; Sun, 29 Dec 2013 19:39:33 -0500
Received: from nodalink.pck.nerim.net ([62.212.105.220]:55159
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VxQtE-0006mJ-78
	for qemu-devel@nongnu.org; Sun, 29 Dec 2013 19:39:28 -0500
Date: Mon, 30 Dec 2013 01:39:19 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20131230003919.GA3032@irqsave.net>
References: <1388363614-25411-1-git-send-email-loic@dachary.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1388363614-25411-1-git-send-email-loic@dachary.org>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant
 in qemu-iotests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Loic Dachary <loic@dachary.org>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Le Monday 30 Dec 2013 =E0 01:33:34 (+0100), Loic Dachary a =E9crit :
> Stash the rbd stderr and stdout because it also contains human readable
> progress messages : Removing image: 3% complete... in addition to
> potential error messages.
>=20
> Display the stashed output if rbd exits on error.
>=20
> Signed-off-by: Loic Dachary <loic@dachary.org>
> ---
>  tests/qemu-iotests/common.rc | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.r=
c
> index 28ba0d9..af66bbd 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -189,7 +189,11 @@ _cleanup_test_img()
>              ;;
> =20
>          rbd)
> -            rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null
> +            if ! rbd rm "$TEST_DIR/t.$IMGFMT" > $TEST_DIR/rbd.out 2>&1
> +            then
> +                cat $TEST_DIR/rbd.out
> +            fi
> +            rm $TEST_DIR/rbd.out
>              ;;
> =20
>          sheepdog)

Hi Lo=EFc,

Maybe you could filter by modifying _filter_qemu_io.

Best regards

Beno=EEt
> --=20
> 1.8.3.2
>=20
>=20