From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vyd8K-0006d1-4W for qemu-devel@nongnu.org; Thu, 02 Jan 2014 02:56:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vyd8A-0003j0-TV for qemu-devel@nongnu.org; Thu, 02 Jan 2014 02:56:00 -0500 Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:53513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vyd8A-0003ic-LP for qemu-devel@nongnu.org; Thu, 02 Jan 2014 02:55:50 -0500 Received: by mail-ee0-f45.google.com with SMTP id d49so6117567eek.4 for ; Wed, 01 Jan 2014 23:55:49 -0800 (PST) Date: Thu, 2 Jan 2014 15:55:35 +0800 From: Stefan Hajnoczi Message-ID: <20140102075535.GA3509@stefanha-thinkpad.redhat.com> References: <20131211004908.GA19241@rox.home.comstyle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131211004908.GA19241@rox.home.comstyle.com> Subject: Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Brad Smith On Tue, Dec 10, 2013 at 07:49:08PM -0500, Brad Smith wrote: > This resolves the build issue with building the ROMs on OpenBSD on x86 archs. > As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the > whole OS/packages and so forth. The ROMs need to have PIE disabled. This > is my initial attempt at trying to get somehting upstream so that QEMU > both builds out of the box and to resolve the build issue with the > buildbots that has been around for awhile. We have a patch in our ports > tree but it is just the flags hardcoded into the Makefile which obviously > is not appropriate for upstream. > > From the OpenBSD buildbots.. > Building optionrom/multiboot.img > ld: multiboot.o: relocation R_X86_64_16 can not be used when making a shared object; recompile with -fPIC > > Signed-off by: Brad Smith > --- > > Change in v2: > * Fix '==' is not portable syntax. > > Change in v3: > * Rename variables and use compile_prog to detect the presence of the compiler/linker > flags, as suggested by Stefan Weil. Reviewed-by: Stefan Hajnoczi