From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37961)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vzyqb-0005oU-8M
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 20:19:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VzyqW-0000Fd-A9
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 20:19:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:10997)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VzyqW-0000FS-26
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 20:19:12 -0500
Date: Mon, 6 Jan 2014 09:18:43 +0800
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140106011843.GA8817@stefanha-thinkpad.redhat.com>
References: <1388062130-21126-1-git-send-email-pl@kamp.de>
	<CAJSP0QUyhMohV7n22jytTgxtO8hyLgGnRKoxyBrVjuYWaikffA@mail.gmail.com>
	<52C69EDF.7020500@kamp.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52C69EDF.7020500@kamp.de>
Subject: Re: [Qemu-devel] [PATCHv5] block: add native support for NFS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Orit Wasserman <owasserm@redhat.com>, ronnie sahlberg <ronniesahlberg@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>

On Fri, Jan 03, 2014 at 12:28:31PM +0100, Peter Lieven wrote:
> On 03.01.2014 11:37, Stefan Hajnoczi wrote:
> >Looks good.  In order to merge this new block driver qemu-iotests
> >support for nfs is required.  That way the block driver can be exercised
> >and checked for regressions (I guess you performed manual testing
> >during development).
> >
> >Please see tests/qemu-iotests/common for examples of
> >NBD/SSH/Sheepdog/etc support.
> >
> >The qemu-iotests test suite with raw, qcow2, and vmdk formats should
> >work on top of NFS.  Assuming you have an NFS server already running
> >on localhost, something like the following should succeed:
> >
> >   cd tests/qemu-iotests
> >   ln -s ../../x86_64-softmmu/qemu-system-x86_64 qemu
> >   ln -s ../../qemu-img .
> >   ln -s ../../qemu-io .
> >   ./check -nfs # raw format by default
> >   ./check -nfs -qcow2
> >   ./check -nfs -vmdk
> >
> >Maybe -nfs should take the base NFS URI as an argument to allow more
> >flexible test configurations.  It's up to you.
> >
> >More info on qemu-iotests: http://qemu-project.org/Documentation/QemuIoTests
> it seems that several tests are broken since they use commands like
> rm -f or mv and have protocol generic. shall I fix this?

The _cleanup_test_img() function in common.rc has cases for
nbd/rbd/sheepdog.  They don't invoke regular rm(1).  Maybe you need to
add a case for NFS there too.

If you find something broken and can fix it that's great.  If you cannot
fix it please report it so the nbd/rbd/sheepdog/ssh/etc maintainers can
investigate.

Stefan