From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vzzfj-0008TB-Lz for qemu-devel@nongnu.org; Sun, 05 Jan 2014 21:12:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vzzfd-000421-Qx for qemu-devel@nongnu.org; Sun, 05 Jan 2014 21:12:07 -0500 Received: from mail-ee0-f54.google.com ([74.125.83.54]:41518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vzzfd-00041t-K6 for qemu-devel@nongnu.org; Sun, 05 Jan 2014 21:12:01 -0500 Received: by mail-ee0-f54.google.com with SMTP id e51so6490352eek.41 for ; Sun, 05 Jan 2014 18:11:24 -0800 (PST) Date: Mon, 6 Jan 2014 10:11:13 +0800 From: Stefan Hajnoczi Message-ID: <20140106021113.GA9790@stefanha-thinkpad.redhat.com> References: <1387617686-1229-1-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387617686-1229-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 0/3] gluster: conversion to coroutines and supporting write_zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Sat, Dec 21, 2013 at 02:51:23PM +0530, Bharata B Rao wrote: > Hi, > > This series is about converting all the bdrv_aio* implementations in gluster > driver to coroutine based implementations. Read, write, flush and discard > routines are converted. > > This also adds support for .bdrv_co_write_zeroes() in gluster and provides > a new preallocation option with qemu-img (-o preallocation=full) that can > be used for raw images on GlusterFS backend to create fully allocated and > zero-filled images. > > Changes in v2 > ------------- > - Don't use QEMU's AIO infrastructure (BlockDriverAIOCB, qemu_aio_get/release) > at all, instead manage the request structure completely within gluster driver. > - Minor code cleanups. > > Changes in v1 > ------------- > - Removed qemu_gluster_aio_cancel() and associated code. > - Calling qemu_aio_release() from where aiocb is created. > - s/qemu_gluster_aio_rw/qemu_gluster_co_rw. > - Use errno appropriately from read, write, flush, discard and zerofill routines > in gluster driver. > - Fix a memory leak in qemu_gluster_create(). > - Proceed with glfs_zerofill() only if glfs_ftruncate() succeeds in > qemu_gluster_create(). > > > Bharata B Rao (3): > gluster: Convert aio routines into coroutines > gluster: Implement .bdrv_co_write_zeroes for gluster > gluster: Add support for creating zero-filled image > > block/gluster.c | 318 +++++++++++++++++++++++++++++--------------------------- > configure | 8 ++ > 2 files changed, 175 insertions(+), 151 deletions(-) Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan