From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54929)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1W00qj-0004LB-Ox
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 22:27:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1W00qd-0005UI-Pq
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 22:27:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45913)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1W00qd-0005UE-HY
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 22:27:27 -0500
Date: Mon, 6 Jan 2014 11:27:11 +0800
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140106032711.GA14603@stefanha-thinkpad.redhat.com>
References: <1388654332-10303-1-git-send-email-b.galvani@gmail.com>
	<1388654332-10303-2-git-send-email-b.galvani@gmail.com>
	<CAEgOgz5D-BaWRMVnpdkmsw+QtZeYLpZyuZuUg1LLxVv4-s55oQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEgOgz5D-BaWRMVnpdkmsw+QtZeYLpZyuZuUg1LLxVv4-s55oQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] hw/net: add support for Allwinner EMAC
 Fast Ethernet controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Beniamino Galvani <b.galvani@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Li Guang <lig.fnst@cn.fujitsu.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

On Thu, Jan 02, 2014 at 08:25:10PM +1000, Peter Crosthwaite wrote:
> Hi Beniamino,
> 
> On Thu, Jan 2, 2014 at 7:18 PM, Beniamino Galvani <b.galvani@gmail.com> wrote:
> > This patch adds support for the Fast Ethernet MAC found on Allwinner
> > SoCs, together with a basic emulation of Realtek RTL8201CP PHY.
> >
> 
> More a comment for net in general, but I think sooner or later we need
> to move towards a split between phy and mac on the device level.
> continuing the phy-within-mac philosophy is going to make the
> socification efforts awkward. Are MII and friends a busses (as in
> TYPE_BUS) in their own right, and connection of mac and phy has to
> happen on the board level?

I see PHY and MAC split as advantageous because it allows code reuse and
better testing.  The main thing I'd like to see is PHY device tests
using tests/libqtest.h.

If someone wants to implement it, great.  It would make it easier to add
more NIC models in the future.

Regarding SOCification and busses, I'm not sure.  Is it okay to just say
a NIC has-a PHY (i.e. composition)?

Stefan