From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Fok-0003WD-7K for qemu-devel@nongnu.org; Mon, 06 Jan 2014 14:26:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Fof-0004GO-Gu for qemu-devel@nongnu.org; Mon, 06 Jan 2014 14:26:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Fof-0004GI-8k for qemu-devel@nongnu.org; Mon, 06 Jan 2014 14:26:25 -0500 Date: Mon, 6 Jan 2014 14:26:22 -0500 From: Luiz Capitulino Message-ID: <20140106142622.5800f8aa@redhat.com> In-Reply-To: <52CB0195.3040703@suse.de> References: <20140106141354.5d47c6a4@redhat.com> <52CB0195.3040703@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qmp v4 0/6] Add error_abort and associated cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: imammedo@redhat.com, Peter Crosthwaite , qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com On Mon, 06 Jan 2014 20:18:45 +0100 Andreas F=C3=A4rber wrote: > Am 06.01.2014 20:13, schrieb Luiz Capitulino: > > On Wed, 1 Jan 2014 18:46:24 -0800 > > Peter Crosthwaite wrote: > >=20 > >> Following our discussion RE self asserting API calls, here is a spin of > >> my proposal. This series obsoletes the need for _nofail variants for > >> Error ** accepting APIs. Is also greatly reduces the verbosity of calls > >> sites that are currently asserting against errors. > >> > >> Patch 1 is the main event - addition of error_abort. The following > >> patches then cleanup uses of _nofail and assert_no_error(). > >=20 > > Applied to the qmp branch, thanks. >=20 > Please normalize "hw/core/qdev:" to just "qdev:", thanks. Done. You still have time for a Reviewed-by :)