From: Erik de Castro Lopo <mle+tools@mega-nerd.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall
Date: Mon, 6 Jan 2014 14:37:22 +1100 [thread overview]
Message-ID: <20140106143722.073326cad50ba8c5914f4388@mega-nerd.com> (raw)
In-Reply-To: <52CA0D7B.5000301@dawncrow.de>
Hi André,
This looks ok, except that scripts/checkpatch.pl says:
WARNING: braces {} are necessary for all arms of this statement
#36: FILE: linux-user/syscall.c:2254:
+ if (get_user_ual(sockfd, vptr)
[...]
total: 0 errors, 1 warnings, 30 lines checked
Fix that and I'll be happy to slap a "reviewed-by" sticker on it. Be sure
to CC me on the fixed version of the patch.
Cheers,
Erik
--
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
next prev parent reply other threads:[~2014-01-06 3:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 1:57 [Qemu-devel] [PATCH resend] linux-user: Support the accept4 socketcall André Hentschel
2014-01-06 3:37 ` Erik de Castro Lopo [this message]
2014-01-06 8:45 ` Laurent Vivier
2014-01-06 9:14 ` Peter Maydell
2014-01-06 10:21 ` Laurent Vivier
2014-01-06 15:38 ` André Hentschel
2014-01-06 16:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106143722.073326cad50ba8c5914f4388@mega-nerd.com \
--to=mle+tools@mega-nerd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).