From: Luiz Capitulino <lcapitulino@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: mdroth@linux.vnet.ibm.com, mreitz@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema
Date: Mon, 6 Jan 2014 18:18:09 -0500 [thread overview]
Message-ID: <20140106181809.64b77df3@redhat.com> (raw)
In-Reply-To: <1388704234-22498-1-git-send-email-xiawenc@linux.vnet.ibm.com>
On Fri, 3 Jan 2014 07:10:29 +0800
Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
> This series add support for tag/keyword 'event' in qapi-schema.
> A new file was created to store some helper functions in patch 2, patch 4 is
> the test case, patch 5 is a convert example.
>
> The implemention is done by generate API and a batch of parameters for each
> event define, it doesn't generate a struture and visit function in the
> background for every event, so it doesn't support nested structure in the
> define to avoid trouble. A callback layer is added to control the behavior.
> More detail can be found in patch 3's message and incode comments.
The general approach seems good to me. Would be nice to get another
reviewer though, maybe Eric and/or Michael.
next prev parent reply other threads:[~2014-01-06 23:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 23:10 [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema Wenchao Xia
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 1/5] os-posix: include sys/time.h Wenchao Xia
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 2/5] qapi: add event helper functions Wenchao Xia
2014-01-06 22:23 ` Luiz Capitulino
2014-01-07 2:28 ` Wenchao Xia
2014-03-06 18:26 ` Eric Blake
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 3/5] qapi script: add event support by qapi-event.py Wenchao Xia
2014-01-06 23:10 ` Luiz Capitulino
2014-01-06 23:17 ` Luiz Capitulino
2014-01-07 3:24 ` Wenchao Xia
2014-02-14 3:26 ` Wenchao Xia
2014-01-07 2:53 ` Wenchao Xia
2014-03-06 18:49 ` Eric Blake
2014-03-19 2:38 ` Wenchao Xia
2014-03-20 22:29 ` Eric Blake
2014-03-24 0:55 ` Wenchao Xia
2014-03-26 12:42 ` Markus Armbruster
2014-03-26 13:13 ` Benoît Canet
2014-03-27 7:52 ` Wenchao Xia
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 4/5] test: add test cases for qapi event Wenchao Xia
2014-03-06 20:05 ` Eric Blake
2014-01-02 23:10 ` [Qemu-devel] [RFC PATCH V2 5/5] qapi event: convert RTC_CHANGE Wenchao Xia
2014-03-06 20:24 ` Eric Blake
2014-01-06 23:18 ` Luiz Capitulino [this message]
2014-03-06 18:14 ` [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema Eric Blake
2014-03-06 19:58 ` Luiz Capitulino
2014-03-07 1:13 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106181809.64b77df3@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).