From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0JS3-0000Jz-DC for qemu-devel@nongnu.org; Mon, 06 Jan 2014 18:19:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0JRx-00063a-CW for qemu-devel@nongnu.org; Mon, 06 Jan 2014 18:19:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0JRx-00063V-4p for qemu-devel@nongnu.org; Mon, 06 Jan 2014 18:19:13 -0500 Date: Mon, 6 Jan 2014 18:18:09 -0500 From: Luiz Capitulino Message-ID: <20140106181809.64b77df3@redhat.com> In-Reply-To: <1388704234-22498-1-git-send-email-xiawenc@linux.vnet.ibm.com> References: <1388704234-22498-1-git-send-email-xiawenc@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: mdroth@linux.vnet.ibm.com, mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Fri, 3 Jan 2014 07:10:29 +0800 Wenchao Xia wrote: > This series add support for tag/keyword 'event' in qapi-schema. > A new file was created to store some helper functions in patch 2, patch 4 is > the test case, patch 5 is a convert example. > > The implemention is done by generate API and a batch of parameters for each > event define, it doesn't generate a struture and visit function in the > background for every event, so it doesn't support nested structure in the > define to avoid trouble. A callback layer is added to control the behavior. > More detail can be found in patch 3's message and incode comments. The general approach seems good to me. Would be nice to get another reviewer though, maybe Eric and/or Michael.