From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59009)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1W0GZ6-00064y-Lc
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 15:14:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1W0GZ1-00027l-DD
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 15:14:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:3894)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1W0GZ1-00027e-5j
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 15:14:19 -0500
Date: Mon, 6 Jan 2014 15:14:06 -0500
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20140106201405.GB23563@localhost.localdomain>
References: <1388942528-10453-1-git-send-email-pl@kamp.de>
	<1388942528-10453-3-git-send-email-pl@kamp.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1388942528-10453-3-git-send-email-pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCHv2 02/18] qemu-iotests: enable support for
	NFS protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>, owasserm@redhat.com, Federico Simoncelli <fsimonce@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Wenchao Xia <xiawenc@linux.vnet.ibm.com>

On Sun, Jan 05, 2014 at 06:21:52PM +0100, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  tests/qemu-iotests/common    |   22 +++++++++++++++++++---
>  tests/qemu-iotests/common.rc |    3 +++
>  2 files changed, 22 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
> index 8b4e22c..e19673b 100644
> --- a/tests/qemu-iotests/common
> +++ b/tests/qemu-iotests/common
> @@ -144,10 +144,12 @@ check options
>      -vpc                test vpc
>      -vhdx               test vhdx
>      -vmdk               test vmdk
> +    -file               test file (default)
>      -rbd                test rbd
>      -sheepdog           test sheepdog
>      -nbd                test nbd
>      -ssh                test ssh
> +    -nfs                test nfs
>      -xdiff              graphical mode diff
>      -nocache            use O_DIRECT on backing file
>      -misalign           misalign memory allocations
> @@ -211,22 +213,36 @@ testlist options
>              xpand=false
>              ;;
>  
> +        -file)
> +            IMGFMT=file

This should be IMGPROTO, right?

> +            xpand=false
> +            ;;
> +
>          -rbd)
>              IMGPROTO=rbd
>              xpand=false
>              ;;
> +
>          -sheepdog)
>              IMGPROTO=sheepdog
>              xpand=false
>              ;;
> +
>          -nbd)
>              IMGPROTO=nbd
>              xpand=false
>              ;;
> +
>          -ssh)
>              IMGPROTO=ssh
>              xpand=false
>              ;;
> +
> +        -nfs)
> +            IMGPROTO=nfs
> +            xpand=false
> +            ;;
> +
>          -nocache)
>              CACHEMODE="none"
>              CACHEMODE_IS_DEFAULT=false
> @@ -238,10 +254,10 @@ testlist options
>              xpand=false
>              ;;
>  
> -    -valgrind)
> -        valgrind=true
> +        -valgrind)
> +            valgrind=true
>              xpand=false
> -        ;;
> +            ;;
>  
>          -g)        # -g group ... pick from group file
>              group=true
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 28ba0d9..940b863 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -61,6 +61,9 @@ elif [ "$IMGPROTO" = "nbd" ]; then
>  elif [ "$IMGPROTO" = "ssh" ]; then
>      TEST_IMG_FILE=$TEST_DIR/t.$IMGFMT
>      TEST_IMG="ssh://127.0.0.1$TEST_IMG_FILE"
> +elif [ "$IMGPROTO" = "nfs" ]; then
> +    TEST_DIR="nfs://127.0.0.1/$TEST_DIR"
> +    TEST_IMG=$TEST_DIR/t.$IMGFMT
>  else
>      TEST_IMG=$IMGPROTO:$TEST_DIR/t.$IMGFMT
>  fi
> -- 
> 1.7.9.5
>