From: Amit Shah <amit.shah@redhat.com>
To: Gal Hammer <ghammer@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH V5] char: restore read callback on a reattached (hotplug) chardev
Date: Tue, 7 Jan 2014 12:55:53 +0530 [thread overview]
Message-ID: <20140107072553.GB18443@grmbl.mre> (raw)
In-Reply-To: <1387376119-11654-1-git-send-email-ghammer@redhat.com>
On (Wed) 18 Dec 2013 [16:15:19], Gal Hammer wrote:
> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
> set the chr handlers to NULL. However when the device is plugged back,
> its read callback is not restored so data can't be transferred from the
> host to the guest (e.g. via the virtio-serial port).
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1027181
>
> Signed-off-by: Gal Hammer <ghammer@redhat.com>
>
> ---
> qemu-char.c | 21 +++++++++++++++++----
> 1 file changed, 17 insertions(+), 4 deletions(-)
>
> V5: - remove_fd_in_watch in fd_chr_update_read_handler as well.
> - fix pty backend.
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Gerd, could you take a look as well?
Amit
next prev parent reply other threads:[~2014-01-07 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 14:15 [Qemu-devel] [PATCH V5] char: restore read callback on a reattached (hotplug) chardev Gal Hammer
2014-01-07 7:25 ` Amit Shah [this message]
2014-01-16 9:14 ` Gal Hammer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107072553.GB18443@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=aliguori@amazon.com \
--cc=ghammer@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).