From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0R3o-0001VE-1F for qemu-devel@nongnu.org; Tue, 07 Jan 2014 02:26:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0R3i-0008CD-2N for qemu-devel@nongnu.org; Tue, 07 Jan 2014 02:26:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0R3h-0008Bx-Qc for qemu-devel@nongnu.org; Tue, 07 Jan 2014 02:26:41 -0500 Date: Tue, 7 Jan 2014 12:55:53 +0530 From: Amit Shah Message-ID: <20140107072553.GB18443@grmbl.mre> References: <1387376119-11654-1-git-send-email-ghammer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387376119-11654-1-git-send-email-ghammer@redhat.com> Subject: Re: [Qemu-devel] [PATCH V5] char: restore read callback on a reattached (hotplug) chardev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer , Gerd Hoffmann Cc: qemu-devel@nongnu.org, Anthony Liguori On (Wed) 18 Dec 2013 [16:15:19], Gal Hammer wrote: > Fix a bug that was introduced in commit 386a5a1e. A removal of a device > set the chr handlers to NULL. However when the device is plugged back, > its read callback is not restored so data can't be transferred from the > host to the guest (e.g. via the virtio-serial port). > > https://bugzilla.redhat.com/show_bug.cgi?id=1027181 > > Signed-off-by: Gal Hammer > > --- > qemu-char.c | 21 +++++++++++++++++---- > 1 file changed, 17 insertions(+), 4 deletions(-) > > V5: - remove_fd_in_watch in fd_chr_update_read_handler as well. > - fix pty backend. Reviewed-by: Amit Shah Gerd, could you take a look as well? Amit