From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Se6-0000hr-FP for qemu-devel@nongnu.org; Tue, 07 Jan 2014 04:08:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Se1-00025E-Oh for qemu-devel@nongnu.org; Tue, 07 Jan 2014 04:08:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Se1-000254-F2 for qemu-devel@nongnu.org; Tue, 07 Jan 2014 04:08:17 -0500 Date: Tue, 7 Jan 2014 10:08:10 +0100 From: Igor Mammedov Message-ID: <20140107100810.2b361dae@thinkpad> In-Reply-To: <52CB966E.6050600@zytor.com> References: <1362017554-1260-1-git-send-email-hpa@zytor.com> <51501B58.1060300@suse.de> <20130325161515.06a2970b@nial.usersys.redhat.com> <51509B0E.40804@zytor.com> <20130325190537.GH8494@otherpad.lan.raisama.net> <5150B77B.7060207@zytor.com> <20130325205636.GK8494@otherpad.lan.raisama.net> <52CB966E.6050600@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 1/3] target-i386: Add 486sx, old486, and old486sx CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "H. Peter Anvin" Cc: Anthony Liguori , Orit Wasserman , Eduardo Habkost , Andreas =?ISO-8859-1?B?RuRyYmVy?= , qemu-devel@nongnu.org On Mon, 06 Jan 2014 21:53:50 -0800 "H. Peter Anvin" wrote: > On 03/25/2013 01:56 PM, Eduardo Habkost wrote: > > > >> > >> It needs to be possible to fix bugs.... > > > > It is possible to fix them today: just write a compat function or add a > > global variable that is handled by cpu_x86_init(), and call it from the > > pc-1.3 machine-type init function. See disable_kvm_pv_eoi() and > > enable_compat_apic_id_mode(), for example. > > > > The difference is that this will be much easier once we introduce the > > static properties: then you just need to add the compat property values > > to the compat_props field on the machine-type struct. > > > > Hi guys, > > Any movement on this in the past year? currently, it's possible to use compat properties for fixing 'model' field, see f8e6a11aecc9 "target-i386: Set model=6 on qemu64 & qemu32 CPU models" as an example. As for using compat properties for feature bits, we are getting closer to it, there is a discussion on how to proceed with feature bits conversion that will allow it. http://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg02707.html > > -hpa > > -- Regards, Igor