From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.crosthwaite@xilinx.com, Kewei Yu <keweihk@gmail.com>,
qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail
Date: Tue, 7 Jan 2014 18:00:45 +0100 [thread overview]
Message-ID: <20140107170045.GF11257@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <52CC121B.1010001@redhat.com>
Am 07.01.2014 um 15:41 hat Paolo Bonzini geschrieben:
> Il 06/01/2014 07:05, Kewei Yu ha scritto:
> > When we disable vnc from "./configure", QEMU can't use the vnc option.
> > So qtest can't use the "vnc -none ", otherwise "make check" fails.
> > If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it.
> >
> > Signed-off-by: Kewei Yu <keweihk@gmail.com>
> > ---
> > v2: Consolidate VNC macro's #ifdef'ery to one central point (tests/libqtest.c).
> > v3: Fix the spelling and terminology error: "s/disabling/disable; s/the\ qemu/QEMU; s/hangs/fails;"
> > v4: If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it.
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Thanks, applied to the block branch.
Kevin
next prev parent reply other threads:[~2014-01-07 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 6:05 [Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail Kewei Yu
2014-01-07 14:41 ` Paolo Bonzini
2014-01-07 17:00 ` Kevin Wolf [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-06 7:41 Kewei Yu
2014-01-06 7:57 ` Kewei Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107170045.GF11257@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=afaerber@suse.de \
--cc=keweihk@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).