From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0a1U-0006Wx-Pc for qemu-devel@nongnu.org; Tue, 07 Jan 2014 12:01:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0a1O-00045V-FT for qemu-devel@nongnu.org; Tue, 07 Jan 2014 12:01:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0a1O-00045C-6t for qemu-devel@nongnu.org; Tue, 07 Jan 2014 12:00:54 -0500 Date: Tue, 7 Jan 2014 18:00:45 +0100 From: Kevin Wolf Message-ID: <20140107170045.GF11257@dhcp-200-207.str.redhat.com> References: <1388988324-25281-1-git-send-email-keweihk@gmail.com> <52CC121B.1010001@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52CC121B.1010001@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.crosthwaite@xilinx.com, Kewei Yu , qemu-devel@nongnu.org, afaerber@suse.de Am 07.01.2014 um 15:41 hat Paolo Bonzini geschrieben: > Il 06/01/2014 07:05, Kewei Yu ha scritto: > > When we disable vnc from "./configure", QEMU can't use the vnc option. > > So qtest can't use the "vnc -none ", otherwise "make check" fails. > > If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it. > > > > Signed-off-by: Kewei Yu > > --- > > v2: Consolidate VNC macro's #ifdef'ery to one central point (tests/libqtest.c). > > v3: Fix the spelling and terminology error: "s/disabling/disable; s/the\ qemu/QEMU; s/hangs/fails;" > > v4: If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it. > > Reviewed-by: Paolo Bonzini Thanks, applied to the block branch. Kevin