Re: [Qemu-devel] [PATCH v8 02/12] qapi: Add BlockOperationType enum

[Stefan Hajnoczi <stefanha@redhat.com>]

On Wed, Jan 08, 2014 at 10:28:59AM +0800, Fam Zheng wrote:
> On 2014年01月03日 18:09, Stefan Hajnoczi wrote:
> >On Fri, Dec 13, 2013 at 03:35:10PM +0800, Fam Zheng wrote:
> >>This adds the enum of all the operations that can be taken on a block
> >>device.
> >>
> >>Signed-off-by: Fam Zheng <famz@redhat.com>
> >>---
> >>  qapi-schema.json | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 50 insertions(+)
> >>
> >>diff --git a/qapi-schema.json b/qapi-schema.json
> >>index d6f8615..8e982a2 100644
> >>--- a/qapi-schema.json
> >>+++ b/qapi-schema.json
> >>@@ -1440,6 +1440,56 @@
> >>    'data': ['commit', 'stream', 'mirror', 'backup'] }
> >>
> >>  ##
> >>+# @BlockOperationType
> >>+#
> >>+# Type of a block operation. (since 2.0)
> >
> >Why is this exposed in qapi-schema.json?  The blockers concept is
> >internal to QEMU and not exposed via QMP.
> >
> 
> I plan to add it into block information (query-block, for example).
> But in follow up patches. It could be useful for user to check which
> commands/operations are possible without trial-and-fail, when we put
> more and more complicated state and configuration into the BDS
> graph.

Can you make it internal for now and expose via QMP if necessary later?

I think we shouldn't commit to public APIs unless they are ready and
provide a useful service, since we cannot change them.

Stefan