qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Loic Dachary <loic@dachary.org>
Cc: Josh Durgin <josh.durgin@inktank.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests
Date: Wed, 8 Jan 2014 12:33:49 +0800	[thread overview]
Message-ID: <20140108043349.GF30570@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <52CAD0D1.8080508@dachary.org>

On Mon, Jan 06, 2014 at 04:50:41PM +0100, Loic Dachary wrote:
> 
> 
> On 06/01/2014 03:23, Stefan Hajnoczi wrote:
> > On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote:
> >> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> >> index 28ba0d9..af66bbd 100644
> >> --- a/tests/qemu-iotests/common.rc
> >> +++ b/tests/qemu-iotests/common.rc
> >> @@ -189,7 +189,11 @@ _cleanup_test_img()
> >>              ;;
> >>  
> >>          rbd)
> >> -            rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null
> > 
> > stderr will be displayed.  Why isn't this enough?
> > 
> 
> Because the progress of the removal operation will be displayed on stderr. rbd outputs on stderr even when there is no error.

Is that a bug in the rbd tool which should be fixed?  Either by printing
progress to stdout or by adding a --quiet option?

  reply	other threads:[~2014-01-08  4:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30  0:33 [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests Loic Dachary
2013-12-30  0:39 ` Benoît Canet
2013-12-30  0:50   ` Loic Dachary
2014-01-06  2:23 ` Stefan Hajnoczi
2014-01-06 15:50   ` Loic Dachary
2014-01-08  4:33     ` Stefan Hajnoczi [this message]
2014-01-08  8:22       ` Loic Dachary
2014-01-08 20:05 ` [Qemu-devel] [PATCH v2] " Loic Dachary
2014-01-08 21:25   ` Josh Durgin
2014-01-09  1:45   ` Stefan Hajnoczi
2014-02-16 16:03     ` Benoît Canet
2014-02-27 15:22   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140108043349.GF30570@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=josh.durgin@inktank.com \
    --cc=loic@dachary.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).