From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0kqE-0004nV-Pq for qemu-devel@nongnu.org; Tue, 07 Jan 2014 23:34:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0kq6-0000VK-Cy for qemu-devel@nongnu.org; Tue, 07 Jan 2014 23:34:06 -0500 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:44133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0kq6-0000V9-6K for qemu-devel@nongnu.org; Tue, 07 Jan 2014 23:33:58 -0500 Received: by mail-ea0-f176.google.com with SMTP id h14so548186eaj.21 for ; Tue, 07 Jan 2014 20:33:57 -0800 (PST) Date: Wed, 8 Jan 2014 12:33:49 +0800 From: Stefan Hajnoczi Message-ID: <20140108043349.GF30570@stefanha-thinkpad.redhat.com> References: <1388363614-25411-1-git-send-email-loic@dachary.org> <20140106022338.GC9790@stefanha-thinkpad.redhat.com> <52CAD0D1.8080508@dachary.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52CAD0D1.8080508@dachary.org> Subject: Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Loic Dachary Cc: Josh Durgin , qemu-devel@nongnu.org On Mon, Jan 06, 2014 at 04:50:41PM +0100, Loic Dachary wrote: > > > On 06/01/2014 03:23, Stefan Hajnoczi wrote: > > On Mon, Dec 30, 2013 at 01:33:34AM +0100, Loic Dachary wrote: > >> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc > >> index 28ba0d9..af66bbd 100644 > >> --- a/tests/qemu-iotests/common.rc > >> +++ b/tests/qemu-iotests/common.rc > >> @@ -189,7 +189,11 @@ _cleanup_test_img() > >> ;; > >> > >> rbd) > >> - rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null > > > > stderr will be displayed. Why isn't this enough? > > > > Because the progress of the removal operation will be displayed on stderr. rbd outputs on stderr even when there is no error. Is that a bug in the rbd tool which should be fixed? Either by printing progress to stdout or by adding a --quiet option?