From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Yan Vugenfirer <yvugenfi@redhat.com>,
qemu-devel list <qemu-devel@nongnu.org>,
Ronen Hod <rhod@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Dmitry Fleytman <dfleytma@redhat.com>,
Miki Mishael <mmishael@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf
Date: Wed, 8 Jan 2014 18:38:39 +0200 [thread overview]
Message-ID: <20140108163839.GB16822@redhat.com> (raw)
In-Reply-To: <52CD78C4.8070403@redhat.com>
On Wed, Jan 08, 2014 at 05:11:48PM +0100, Paolo Bonzini wrote:
> Il 08/01/2014 16:07, Yan Vugenfirer ha scritto:
> >>>
> >>> +%QEMU-PCI_SERIAL_1_PORT%=ComPort_inst1,
> >>> PCI\VEN_1B36&DEV_0002&SUBSYS_11001AF4&REV_01
> >>> +%QEMU-PCI_SERIAL_2_PORT%=ComPort_inst2,
> >>> PCI\VEN_1B36&DEV_0003&SUBSYS_11001AF4&REV_01
> >>> +%QEMU-PCI_SERIAL_4_PORT%=ComPort_inst4,
> >>> PCI\VEN_1B36&DEV_0004&SUBSYS_11001AF4&REV_01
> >>
> >> I think checking the subsystem is not necessary (and I think downstreams
> >> could legitimately change it). Can you check CC and REV but not SUBSYS?
> >
> > PNP ID can be reduced to vendor and device ID only, for example:
> > PCI\VEN_1B36&DEV_0002 . But in this case we cannot check revision.
>
> Gerd, Michael, what do you think is better? Not check revision, or
> enforcing subsystem?
>
> Paolo
AFAIK the 0.9.X spec explicitly says you should look at subsystem.
--
MST
next prev parent reply other threads:[~2014-01-08 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 15:04 [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf Miki Mishael
2014-01-07 14:45 ` Paolo Bonzini
2014-01-08 15:07 ` Yan Vugenfirer
2014-01-08 16:11 ` Paolo Bonzini
2014-01-08 16:38 ` Michael S. Tsirkin [this message]
2014-01-13 10:13 ` Gerd Hoffmann
2014-01-13 14:48 ` Michael S. Tsirkin
2014-01-13 14:56 ` Paolo Bonzini
2014-01-13 15:03 ` Michael S. Tsirkin
2014-01-13 15:04 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2014-01-16 12:18 [Qemu-devel] [PATCH V2 00/01] " Miki Mishael
2014-01-16 12:18 ` [Qemu-devel] [PATCH] " Miki Mishael
2014-01-16 14:44 ` Gerd Hoffmann
2014-01-16 21:12 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108163839.GB16822@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=dfleytma@redhat.com \
--cc=kraxel@redhat.com \
--cc=mmishael@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rhod@redhat.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).