From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34453)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W0wLN-0007sE-PK
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:51:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W0wLH-0006Co-P4
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:51:01 -0500
Received: from mx1.redhat.com ([209.132.183.28]:11333)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W0wLH-0006Ci-GV
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 11:50:55 -0500
Date: Wed, 8 Jan 2014 18:50:42 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140108165042.GA17404@redhat.com>
References: <1388269852-21198-1-git-send-email-imammedo@redhat.com>
	<1388269852-21198-8-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1388269852-21198-8-git-send-email-imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 7/9] pc: ACPI: expose PRST IO range via _CRS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: hutao@cn.fujitsu.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, chen.fan.fnst@cn.fujitsu.com, kraxel@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, afaerber@suse.de

On Sat, Dec 28, 2013 at 11:30:50PM +0100, Igor Mammedov wrote:
> .. so OSPM could notice resource conflict if there is any.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  hw/i386/acpi-dsdt-cpu-hotplug.dsl | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> index 1dfbb4f..869aa00 100644
> --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> @@ -52,7 +52,8 @@ Scope(\_SB) {
>          Sleep(200)
>      }
>  
> -    OperationRegion(PRST, SystemIO, CPU_STATUS_BASE, 32)
> +#define CPU_STATUS_LEN 32
> +    OperationRegion(PRST, SystemIO, CPU_STATUS_BASE, CPU_STATUS_LEN)
>      Field(PRST, ByteAcc, NoLock, Preserve) {
>          PRS, 256
>      }
> @@ -89,4 +90,12 @@ Scope(\_SB) {
>              Increment(Local0)
>          }
>      }
> +
> +    Device(PRES) {

How about 

#define CPU_HOTPLUG_RESOURCE_DEVICE PRES
or something?

> +        Name(_HID, "ACPI0004")

Does this need to be marked as hidden with _STA?

> +
> +        Name(_CRS, ResourceTemplate() {
> +            IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS_LEN)
> +        })
> +    }
>  }
> -- 
> 1.8.4.2