From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47121)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W0xDt-0001Io-6Q
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 12:47:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W0xDn-0005xS-G2
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 12:47:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:27234)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W0xDn-0005wx-6u
	for qemu-devel@nongnu.org; Wed, 08 Jan 2014 12:47:15 -0500
Date: Wed, 8 Jan 2014 19:47:03 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140108174703.GG17404@redhat.com>
References: <1388269852-21198-1-git-send-email-imammedo@redhat.com>
	<1388269852-21198-4-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1388269852-21198-4-git-send-email-imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/9] pc: rebuild ACPI hex files if included
 *.dsl are touched
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: hutao@cn.fujitsu.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, chen.fan.fnst@cn.fujitsu.com, kraxel@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, afaerber@suse.de

On Sat, Dec 28, 2013 at 11:30:46PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  hw/i386/Makefile.objs | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> index 09ac433..edf5256 100644
> --- a/hw/i386/Makefile.objs
> +++ b/hw/i386/Makefile.objs
> @@ -16,7 +16,12 @@ iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \
>  
>  ifdef IASL
>  #IASL Present. Generate hex files from .dsl
> -hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.dsl $(SRC_PATH)/scripts/acpi_extract_preprocess.py $(SRC_PATH)/scripts/acpi_extract.py
> +DSL_DEPS = $(SRC_PATH)/hw/i386/%.dsl \
> +	$(SRC_PATH)/scripts/acpi_extract_preprocess.py \
> +	$(SRC_PATH)/scripts/acpi_extract.py \
> +	$(SRC_PATH)/hw/i386/acpi-dsdt-*.dsl
> +
> +hw/i386/%.hex: $(DSL_DEPS)
>  	$(call quiet-command, cpp -P $< -o $*.dsl.i.orig, "  CPP $(TARGET_DIR)$*.dsl.i.orig")
>  	$(call quiet-command, $(PYTHON) $(SRC_PATH)/scripts/acpi_extract_preprocess.py $*.dsl.i.orig > $*.dsl.i, "  ACPI_PREPROCESS $(TARGET_DIR)$*.dsl.i")
>  	$(call quiet-command, $(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l -tc -p $* $*.dsl.i $(if $(V), , > /dev/null) 2>&1 ,"  IASL $(TARGET_DIR)$*.dsl.i")

It's generally nasty to have rules that generate files already in
the source tree. In partuclar people expect make clean to get
back the original tree.
How about only doing this when some variable is defined?

> -- 
> 1.8.4.2