From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1Brx-0000Qn-Aa for qemu-devel@nongnu.org; Thu, 09 Jan 2014 04:25:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1Brs-0002tJ-6p for qemu-devel@nongnu.org; Thu, 09 Jan 2014 04:25:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1Brr-0002tF-OO for qemu-devel@nongnu.org; Thu, 09 Jan 2014 04:25:35 -0500 Date: Thu, 9 Jan 2014 10:25:23 +0100 From: Igor Mammedov Message-ID: <20140109102523.21d23beb@nial.usersys.redhat.com> In-Reply-To: <20140108174703.GG17404@redhat.com> References: <1388269852-21198-1-git-send-email-imammedo@redhat.com> <1388269852-21198-4-git-send-email-imammedo@redhat.com> <20140108174703.GG17404@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/9] pc: rebuild ACPI hex files if included *.dsl are touched List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: hutao@cn.fujitsu.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, chen.fan.fnst@cn.fujitsu.com, kraxel@redhat.com, anthony.perard@citrix.com, lersek@redhat.com, afaerber@suse.de On Wed, 8 Jan 2014 19:47:03 +0200 "Michael S. Tsirkin" wrote: > On Sat, Dec 28, 2013 at 11:30:46PM +0100, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/i386/Makefile.objs | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > >=20 > > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs > > index 09ac433..edf5256 100644 > > --- a/hw/i386/Makefile.objs > > +++ b/hw/i386/Makefile.objs > > @@ -16,7 +16,12 @@ iasl-option=3D$(shell if test -z "`$(1) $(2) 2>&1 > = /dev/null`" \ > > =20 > > ifdef IASL > > #IASL Present. Generate hex files from .dsl > > -hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.dsl $(SRC_PATH)/scripts/acpi_extr= act_preprocess.py $(SRC_PATH)/scripts/acpi_extract.py > > +DSL_DEPS =3D $(SRC_PATH)/hw/i386/%.dsl \ > > + $(SRC_PATH)/scripts/acpi_extract_preprocess.py \ > > + $(SRC_PATH)/scripts/acpi_extract.py \ > > + $(SRC_PATH)/hw/i386/acpi-dsdt-*.dsl > > + > > +hw/i386/%.hex: $(DSL_DEPS) > > $(call quiet-command, cpp -P $< -o $*.dsl.i.orig, " CPP $(TARGET_DIR= )$*.dsl.i.orig") > > $(call quiet-command, $(PYTHON) $(SRC_PATH)/scripts/acpi_extract_prep= rocess.py $*.dsl.i.orig > $*.dsl.i, " ACPI_PREPROCESS $(TARGET_DIR)$*.dsl.= i") > > $(call quiet-command, $(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l= -tc -p $* $*.dsl.i $(if $(V), , > /dev/null) 2>&1 ," IASL $(TARGET_DIR)$*= .dsl.i") >=20 > It's generally nasty to have rules that generate files already in > the source tree. In partuclar people expect make clean to get > back the original tree. > How about only doing this when some variable is defined? I'm not sure if I get you, %.hex files in source tree are always rebuilt if= IASL present (i.e. it's just cached copy for IASL-less case). =46rom my POV as developer if I touched included file then dependent files must be rebuild even without 'make clean'. Otherwise it would break bisecti= on for example where stale table is used due to lack of deps. Patch just fixes a bug in build process, i.e. adds deps on included files. It's crude but still an improvement over current behavior. All that said, I don't care much about this patch and can drop it. >=20 > > --=20 > > 1.8.4.2