From: "Noonan, Steven" <snoonan@amazon.com>
To: Brad Smith <brad@comstyle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Steven Noonan <steven@uplinklabs.net>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags
Date: Thu, 9 Jan 2014 15:31:43 -0800 [thread overview]
Message-ID: <20140109233142.GB11226@amazon.com> (raw)
In-Reply-To: <52CF2E2F.4060005@comstyle.com>
On Thu, Jan 09, 2014 at 06:18:07PM -0500, Brad Smith wrote:
> On 09/01/14 5:40 PM, Paolo Bonzini wrote:
> >Il 09/01/2014 22:55, Steven Noonan ha scritto:
> >>From: Steven Noonan <snoonan@amazon.com>
> >>
> >>The -fstack-protector flag family is useful for ensuring safety and for
> >>debugging, but has a performance impact. Here's a boot time comparison between
> >>a QEMU build of qemu-system-arm with and without the -fstack-protector-all
> >>flag:
> >>
> >> # WITHOUT -fstack-protector-all
> >> [root@localhost ~]# systemd-analyze
> >> Startup finished in 1.744s (kernel) + 11.345s (initrd) + 47.164s (userspace) = 1min 255ms
> >>
> >> # WITH -fstack-protector-all
> >> [root@localhost ~]# systemd-analyze
> >> Startup finished in 1.843s (kernel) + 12.262s (initrd) + 1min 3.480s (userspace) = 1min 17.587s
> >
> >Can you try -fstack-protector-strong?
> >
> >Probably the right thing to do is to pick in order
> >-fstack-protector-strong, -fstack-protector, and nothing.
>
> +1
>
I think there should still be an option to turn it off, but I agree that
there are probably better flags than -fstack-protector-all. I'll try
those out and post an update here probably later this evening.
next prev parent reply other threads:[~2014-01-09 23:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 21:55 [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags Steven Noonan
2014-01-09 21:55 ` [Qemu-devel] [PATCH 2/3] virtfs-proxy-helper.c: fix compile error Steven Noonan
2014-01-09 21:55 ` [Qemu-devel] [PATCH 3/3] Makefile: add bios-256k.bin to BLOBS Steven Noonan
2014-01-09 23:27 ` Peter Maydell
2014-01-09 23:30 ` Noonan, Steven
2014-01-10 9:12 ` Markus Armbruster
2014-01-09 22:30 ` [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags Peter Maydell
2014-01-09 22:40 ` Paolo Bonzini
2014-01-09 23:18 ` Brad Smith
2014-01-09 23:31 ` Noonan, Steven [this message]
2014-01-11 2:36 ` Noonan, Steven
2014-01-11 7:46 ` Stefan Weil
2014-01-13 11:53 ` Paolo Bonzini
2014-01-13 20:00 ` [Qemu-devel] [PATCH] " Steven Noonan
2014-01-13 20:27 ` Stefan Weil
2014-01-13 20:38 ` Noonan, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109233142.GB11226@amazon.com \
--to=snoonan@amazon.com \
--cc=aliguori@amazon.com \
--cc=brad@comstyle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=steven@uplinklabs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).