From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1Vbv-0002Iw-Kv for qemu-devel@nongnu.org; Fri, 10 Jan 2014 01:30:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1Vbr-0008Sn-C3 for qemu-devel@nongnu.org; Fri, 10 Jan 2014 01:30:27 -0500 Received: from afflict.kos.to ([92.243.29.197]:42637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1Vbr-0008SY-4q for qemu-devel@nongnu.org; Fri, 10 Jan 2014 01:30:23 -0500 Date: Fri, 10 Jan 2014 08:30:20 +0200 From: Riku Voipio Message-ID: <20140110063020.GA27003@afflict.kos.to> References: <1389258650-22834-1-git-send-email-will.newton@linaro.org> <52CE8FFA.5060800@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <52CE8FFA.5060800@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Will Newton , qemu-devel@nongnu.org Hi, On Thu, Jan 09, 2014 at 01:03:06PM +0100, Andreas F=C3=A4rber wrote: > "... of load_elf_binary() and load_flt_binary()" - Riku can you fix pls= ? Changed and added to queque. Riku > Am 09.01.2014 10:10, schrieb Will Newton: > > The regs parameter is not used anywhere, so remove it. > >=20 > > Signed-off-by: Will Newton > > --- > > linux-user/elfload.c | 3 +-- > > linux-user/flatload.c | 3 +-- > > linux-user/linuxload.c | 4 ++-- > > linux-user/qemu.h | 6 ++---- > > 4 files changed, 6 insertions(+), 10 deletions(-) >=20 > Please CC your colleague as the maintainer, scripts/get_maintainer.pl > --nogit-fallback can help automate that. > Also you probably wanted patches@linaro.org, too. ;) >=20 > That said, patch contents look fine, without knowing the history, >=20 > Reviewed-by: Andreas F=C3=A4rber >=20 > Cheers, > Andreas >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg