From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46985)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W2bTi-0001qZ-Eg
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 01:58:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W2bTa-0000s1-16
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 01:58:30 -0500
Received: from mail-ee0-x22b.google.com ([2a00:1450:4013:c00::22b]:51800)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W2bTZ-0000rv-R7
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 01:58:21 -0500
Received: by mail-ee0-f43.google.com with SMTP id c41so347634eek.30
	for <qemu-devel@nongnu.org>; Sun, 12 Jan 2014 22:58:21 -0800 (PST)
Date: Mon, 13 Jan 2014 14:58:04 +0800
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140113065804.GD14770@stefanha-thinkpad.redhat.com>
References: <1386936303-7697-1-git-send-email-v.maffione@gmail.com>
	<1386936303-7697-2-git-send-email-v.maffione@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1386936303-7697-2-git-send-email-v.maffione@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] net: extend NetClientInfo for
 offloading manipulations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vincenzo Maffione <v.maffione@gmail.com>
Cc: aliguori@amazon.com, marcel.a@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it

On Fri, Dec 13, 2013 at 01:04:59PM +0100, Vincenzo Maffione wrote:
> diff --git a/include/net/net.h b/include/net/net.h
> index 11e1468..f5b5bae 100644
> --- a/include/net/net.h
> +++ b/include/net/net.h
> @@ -50,6 +50,12 @@ typedef void (NetCleanup) (NetClientState *);
>  typedef void (LinkStatusChanged)(NetClientState *);
>  typedef void (NetClientDestructor)(NetClientState *);
>  typedef RxFilterInfo *(QueryRxFilter)(NetClientState *);
> +typedef bool (HasUfo)(NetClientState *);
> +typedef int (HasVnetHdr)(NetClientState *);

Please change the return type to bool.  bool is easier to understand
since the reader can be sure the variable only takes true/false values.

> +typedef int (HasVnetHdrLen)(NetClientState *, int);

Please change the return type to bool.