From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2c1b-0000t4-DF for qemu-devel@nongnu.org; Mon, 13 Jan 2014 02:33:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2c1S-0002M3-SJ for qemu-devel@nongnu.org; Mon, 13 Jan 2014 02:33:31 -0500 Received: from mail-ee0-x232.google.com ([2a00:1450:4013:c00::232]:36376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2c1S-0002Lz-Kw for qemu-devel@nongnu.org; Mon, 13 Jan 2014 02:33:22 -0500 Received: by mail-ee0-f50.google.com with SMTP id d17so496658eek.37 for ; Sun, 12 Jan 2014 23:33:21 -0800 (PST) Date: Mon, 13 Jan 2014 15:33:11 +0800 From: Stefan Hajnoczi Message-ID: <20140113073311.GF14770@stefanha-thinkpad.redhat.com> References: <1386936303-7697-1-git-send-email-v.maffione@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386936303-7697-1-git-send-email-v.maffione@gmail.com> Subject: Re: [Qemu-devel] [PATCH 0/5] Add netmap backend offloadings support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincenzo Maffione Cc: aliguori@amazon.com, marcel.a@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it On Fri, Dec 13, 2013 at 01:04:58PM +0100, Vincenzo Maffione wrote: > The purpose of this patch series is to add offloadings support > (TSO/UFO/CSUM) to the netmap network backend, and make it possible > for the paravirtual network frontends (virtio-net and vmxnet3) to > use it. > In order to achieve this, these patches extend the existing > net.h interface to add abstract operations through which a network > frontend can manipulate backend offloading features, instead of > directly calling TAP-specific functions. > > Guest-to-guest performance before this patches for virtio-net + netmap: > > TCP_STREAM 5.0 Gbps > TCP_RR 12.7 Gbps > UDP_STREAM (64-bytes) 790 Kpps > > Guest-to-guest performance after this patches for virtio-net + netmap: > > TCP_STREAM 21.4 Gbps > TCP_RR 12.7 Gbps > UDP_STREAM (64-bytes) 790 Kpps > > Experiment details: > - Processor: Intel i7-3770K CPU @ 3.50GHz (8 cores) > - Memory @ 1333 MHz > - Host O.S.: Archlinux with Linux 3.11 > - Guest O.S.: Archlinux with Linux 3.11 > > - QEMU command line: > qemu-system-x86_64 archdisk.qcow -snapshot -enable-kvm -device virtio-net-pci,ioeventfd=on,mac=00:AA:BB:CC:DD:01,netdev=mynet -netdev netmap,ifname=vale0:01,id=mynet -smp 2 -vga std -m 3G > > > Vincenzo Maffione (5): > net: extend NetClientInfo for offloading manipulations > net: TAP uses NetClientInfo offloading callbacks > net: virtio-net and vmxnet3 use offloading API > net: add offloadings support to netmap backend > net: virtio-net and vmxnet3 can use netmap offloadings > > hw/net/virtio-net.c | 16 +++++--------- > hw/net/vmxnet3.c | 12 +++++----- > include/net/net.h | 19 ++++++++++++++++ > net/net.c | 55 +++++++++++++++++++++++++++++++++++++++++++++ > net/netmap.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++- > net/tap.c | 6 +++++ > 6 files changed, 154 insertions(+), 18 deletions(-) Overall I'm happy with the approach. I left comments about cleaning up the tap interface that you're moving to NetClient, and about supporting runtime offload feature toggling.