* [Qemu-devel] [PATCH] tests: Correct comment for qdict_array_split test
@ 2014-01-12 16:01 Max Reitz
2014-01-13 9:29 ` Kevin Wolf
2014-01-13 9:30 ` Markus Armbruster
0 siblings, 2 replies; 3+ messages in thread
From: Max Reitz @ 2014-01-12 16:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Stefan Hajnoczi, Max Reitz
The comment explaining the expected behavior was actually mistaken (the
test code, however, was not). Fix this.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/check-qdict.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/check-qdict.c b/tests/check-qdict.c
index d4ec631..7a7461b 100644
--- a/tests/check-qdict.c
+++ b/tests/check-qdict.c
@@ -323,11 +323,11 @@ static void qdict_array_split_test(void)
*
* [
* {
- * "a": 42
+ * "a": 42,
+ * "b": 23
* },
* {
- * "x": 0,
- * "y": 1
+ * "x": 0
* }
* ]
*
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tests: Correct comment for qdict_array_split test
2014-01-12 16:01 [Qemu-devel] [PATCH] tests: Correct comment for qdict_array_split test Max Reitz
@ 2014-01-13 9:29 ` Kevin Wolf
2014-01-13 9:30 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2014-01-13 9:29 UTC (permalink / raw)
To: Max Reitz; +Cc: qemu-devel, Stefan Hajnoczi
Am 12.01.2014 um 17:01 hat Max Reitz geschrieben:
> The comment explaining the expected behavior was actually mistaken (the
> test code, however, was not). Fix this.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Thanks. As the original patch wasn't merged into qemu.git master yet, I
have updated it with this fix.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: Correct comment for qdict_array_split test
2014-01-12 16:01 [Qemu-devel] [PATCH] tests: Correct comment for qdict_array_split test Max Reitz
2014-01-13 9:29 ` Kevin Wolf
@ 2014-01-13 9:30 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2014-01-13 9:30 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, qemu-devel, Stefan Hajnoczi
Max Reitz <mreitz@redhat.com> writes:
> The comment explaining the expected behavior was actually mistaken (the
> test code, however, was not). Fix this.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/check-qdict.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/check-qdict.c b/tests/check-qdict.c
> index d4ec631..7a7461b 100644
> --- a/tests/check-qdict.c
> +++ b/tests/check-qdict.c
> @@ -323,11 +323,11 @@ static void qdict_array_split_test(void)
> *
> * [
> * {
> - * "a": 42
> + * "a": 42,
> + * "b": 23
> * },
> * {
> - * "x": 0,
> - * "y": 1
> + * "x": 0
> * }
> * ]
> *
Looks like this is on top of "[PATCH v7 21/24] tests: Add test for
qdict_array_split()", which hasn't been committed, yet. Squash it in?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-13 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-12 16:01 [Qemu-devel] [PATCH] tests: Correct comment for qdict_array_split test Max Reitz
2014-01-13 9:29 ` Kevin Wolf
2014-01-13 9:30 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).