From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34149)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W2j31-0008KA-RB
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 10:03:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W2j2v-0006gu-Rb
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 10:03:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36929)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W2j2v-0006gi-KN
	for qemu-devel@nongnu.org; Mon, 13 Jan 2014 10:03:21 -0500
Date: Mon, 13 Jan 2014 17:03:11 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140113150311.GB30760@redhat.com>
References: <1388934290-27700-1-git-send-email-mmishael@redhat.com>
	<52CC1310.7070406@redhat.com>
	<DECD048F-03FE-42EB-9358-75B1D1849669@redhat.com>
	<52CD78C4.8070403@redhat.com>
	<1389607987.9142.48.camel@nilsson.home.kraxel.org>
	<20140113144803.GA30636@redhat.com> <52D3FEB1.9040703@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52D3FEB1.9040703@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support
 in qemupciserial.inf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Yan Vugenfirer <yvugenfi@redhat.com>, qemu-devel list <qemu-devel@nongnu.org>, Ronen Hod <rhod@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Dmitry Fleytman <dfleytma@redhat.com>, Miki Mishael <mmishael@redhat.com>

On Mon, Jan 13, 2014 at 03:56:49PM +0100, Paolo Bonzini wrote:
> Il 13/01/2014 15:48, Michael S. Tsirkin ha scritto:
> > 
> >         if (pci_dev->revision != VIRTIO_PCI_ABI_VERSION) {
> >                 printk(KERN_ERR "virtio_pci: expected ABI version %d,
> > got %d\n",
> >                        VIRTIO_PCI_ABI_VERSION, pci_dev->revision);
> >                 return -ENODEV;
> >         }
> > 
> > so it seems better to be consistent.
> > in any case, we must check subsystem ids, the spec is very
> > explicit on this point.
> 
> This is not a virtio device.
> 
> Paolo

oh
I didn't realize that - thought it's virtio serial we are talking about.
In that case I agree with Gerd.