qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
To: qemu-devel@nongnu.org
Cc: ghammer@redhat.com, mdroth@linux.vnet.ibm.com,
	lcapitulino@redhat.com, mitsuhiro.tanino@hds.com,
	rhod@redhat.com, pbonzini@redhat.com, seiji.aguchi@hds.com,
	areis@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] qga: vss-win32: Fix interference with other VSS requesters
Date: Mon, 13 Jan 2014 12:25:14 -0500	[thread overview]
Message-ID: <20140113172514.11163.75410.stgit@helix> (raw)

Current functionarity of qemu-ga VSS provider is limited to implement
filesystems freeze, and doesn't support the creation of shadow copies
within the guest.
However, when no other hardware snapshot provider is installed, VSS may
choose qemu-ga VSS provider to create shadow copies and fail with
VSS_E_UNEXPECTED_PROVIDER_ERROR.
Similar issue occurs when the requester deletes shadow copies.

This patchset fix this issue by telling VSS that the volume is not
supported by qemu-ga VSS provider when it is kicked by other requesters.

It also fixes wrong error handling around OpenEvent/CreateEvent WinAPI,
which returns NULL instead of INVALID_HANDLE_VALUE on errors.

https://bugzilla.redhat.com/show_bug.cgi?id=1036341

---
Tomoki Sekiyama (3):
      qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and CreateEvent
      qga: vss-win32: Fix interference with snapshot creation by other VSS requesters
      qga: vss-win32: Fix interference with snapshot deletion by other VSS request


 qga/vss-win32/provider.cpp  |   21 ++++++++++---
 qga/vss-win32/requester.cpp |   70 ++++++++++++++++++++-----------------------
 2 files changed, 49 insertions(+), 42 deletions(-)

-- 
Tomoki Sekiyama

             reply	other threads:[~2014-01-13 17:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13 17:25 Tomoki Sekiyama [this message]
2014-01-13 17:25 ` [Qemu-devel] [PATCH 1/3] qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and CreateEvent Tomoki Sekiyama
2014-01-14  8:32   ` Gal Hammer
2014-01-19 10:22   ` Yan Vugenfirer
2014-01-13 17:25 ` [Qemu-devel] [PATCH 2/3] qga: vss-win32: Fix interference with snapshot creation by other VSS requesters Tomoki Sekiyama
2014-01-14  8:33   ` Gal Hammer
2014-01-19 10:21   ` Yan Vugenfirer
2014-01-13 17:25 ` [Qemu-devel] [PATCH 3/3] qga: vss-win32: Fix interference with snapshot deletion by other VSS request Tomoki Sekiyama
2014-01-14  8:34   ` Gal Hammer
2014-01-19 10:21   ` Yan Vugenfirer
2014-02-24  0:58 ` [Qemu-devel] [PATCH 0/3] qga: vss-win32: Fix interference with other VSS requesters Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140113172514.11163.75410.stgit@helix \
    --to=tomoki.sekiyama@hds.com \
    --cc=areis@redhat.com \
    --cc=ghammer@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mitsuhiro.tanino@hds.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rhod@redhat.com \
    --cc=seiji.aguchi@hds.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).