From: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
To: qemu-devel@nongnu.org
Cc: ghammer@redhat.com, mdroth@linux.vnet.ibm.com,
lcapitulino@redhat.com, mitsuhiro.tanino@hds.com,
rhod@redhat.com, pbonzini@redhat.com, seiji.aguchi@hds.com,
areis@redhat.com
Subject: [Qemu-devel] [PATCH 3/3] qga: vss-win32: Fix interference with snapshot deletion by other VSS request
Date: Mon, 13 Jan 2014 12:25:39 -0500 [thread overview]
Message-ID: <20140113172539.11163.2952.stgit@helix> (raw)
In-Reply-To: <20140113172514.11163.75410.stgit@helix>
When a VSS requester such as vshadow.exe or diskshadow.exe requests to
delete snapshots, qemu-ga VSS provider's DeleteSnapshots() is also called
and returns E_NOTIMPL, that makes the deletion fail.
To avoid this issue, return S_OK and set values that represent no snapshots
are deleted by qemu-ga VSS provider.
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
---
qga/vss-win32/provider.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp
index b233646..d5129f8 100644
--- a/qga/vss-win32/provider.cpp
+++ b/qga/vss-win32/provider.cpp
@@ -278,7 +278,9 @@ STDMETHODIMP CQGAVssProvider::DeleteSnapshots(
VSS_ID SourceObjectId, VSS_OBJECT_TYPE eSourceObjectType,
BOOL bForceDelete, LONG *plDeletedSnapshots, VSS_ID *pNondeletedSnapshotID)
{
- return E_NOTIMPL;
+ *plDeletedSnapshots = 0;
+ *pNondeletedSnapshotID = SourceObjectId;
+ return S_OK;
}
STDMETHODIMP CQGAVssProvider::BeginPrepareSnapshot(
next prev parent reply other threads:[~2014-01-13 17:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 17:25 [Qemu-devel] [PATCH 0/3] qga: vss-win32: Fix interference with other VSS requesters Tomoki Sekiyama
2014-01-13 17:25 ` [Qemu-devel] [PATCH 1/3] qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and CreateEvent Tomoki Sekiyama
2014-01-14 8:32 ` Gal Hammer
2014-01-19 10:22 ` Yan Vugenfirer
2014-01-13 17:25 ` [Qemu-devel] [PATCH 2/3] qga: vss-win32: Fix interference with snapshot creation by other VSS requesters Tomoki Sekiyama
2014-01-14 8:33 ` Gal Hammer
2014-01-19 10:21 ` Yan Vugenfirer
2014-01-13 17:25 ` Tomoki Sekiyama [this message]
2014-01-14 8:34 ` [Qemu-devel] [PATCH 3/3] qga: vss-win32: Fix interference with snapshot deletion by other VSS request Gal Hammer
2014-01-19 10:21 ` Yan Vugenfirer
2014-02-24 0:58 ` [Qemu-devel] [PATCH 0/3] qga: vss-win32: Fix interference with other VSS requesters Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113172539.11163.2952.stgit@helix \
--to=tomoki.sekiyama@hds.com \
--cc=areis@redhat.com \
--cc=ghammer@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mitsuhiro.tanino@hds.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rhod@redhat.com \
--cc=seiji.aguchi@hds.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).