From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2uLZ-0001Ok-Hk for qemu-devel@nongnu.org; Mon, 13 Jan 2014 22:07:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2uLT-0001un-Do for qemu-devel@nongnu.org; Mon, 13 Jan 2014 22:07:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2uLT-0001ui-5Q for qemu-devel@nongnu.org; Mon, 13 Jan 2014 22:07:15 -0500 Date: Tue, 14 Jan 2014 11:06:58 +0800 From: Fam Zheng Message-ID: <20140114030658.GB9212@T430.nay.redhat.com> References: <1389632394-10130-1-git-send-email-pbonzini@redhat.com> <1389632394-10130-7-git-send-email-pbonzini@redhat.com> <52D4658E.10203@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52D4658E.10203@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, alex@alex.org.uk, Paolo Bonzini , mrezanin@redhat.com, vilanova@ac.upc.edu On Mon, 01/13 14:15, Richard Henderson wrote: > On 01/13/2014 08:59 AM, Paolo Bonzini wrote: > > +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak > > I really really don't like random numbers that make for non-repeatable builds. > It's a quality-assurance nightmare. Can you elaborate this, please? > > If you want a non-random number unique to the build, try > > git log -n1 --format=format:%H > > and perhaps a file containing that hash created by scripts/make-release. What if the source code is not in a git tree, for example a tarball? Thanks, Fam