From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W2yj8-0005zG-JN
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 02:48:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W2yj2-0003eJ-D3
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 02:47:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:28091)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W2yj2-0003eE-4V
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 02:47:52 -0500
Date: Tue, 14 Jan 2014 15:47:39 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140114074739.GA7044@T430.nay.redhat.com>
References: <1389632394-10130-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA9D3SWRH=6bDmpwfCuu+YYQaCqhDyU_KNYHNeBgBYD2kQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA9D3SWRH=6bDmpwfCuu+YYQaCqhDyU_KNYHNeBgBYD2kQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v15 0/9] Shared library module support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Michael Tokarev <mjt@tls.msk.ru>, QEMU Developers <qemu-devel@nongnu.org>, Alex Bligh <alex@alex.org.uk>, Paolo Bonzini <pbonzini@redhat.com>, Miroslav Rezanina <mrezanin@redhat.com>, =?iso-8859-1?Q?Llu=EDs?= Vilanova <vilanova@ac.upc.edu>, Richard Henderson <rth@twiddle.net>

On Mon, 01/13 22:01, Peter Maydell wrote:
> On 13 January 2014 16:59, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > This is based on Fam's patches from October.  Very few changes
> > apart from rebasing:
> >
> > * I split his patch 8 in two parts.  There is benefit in
> > using per-object cflags and libs even before the module-loading
> > machinery gets in.
> >
> > * I added a new patch "darwin: do not use -mdynamic-no-pic".
> > CCing Alex Graf for it.
> >
> > * applied the small change I had requested a small change in patch 2
> >
> > I'm not sending a pull request yet because of these two changes,
> > but I'll be sending one in a few days.
> 
> This doesn't build on MacOSX if you try to enable modules with
> --enable-modules:
> 

module-common.c is missing in patch 6/9, so it failed.

Fam