From: Stefan Hajnoczi <stefanha@gmail.com>
To: Mohamad Gebai <mohamad.gebai@gmail.com>
Cc: Mohamad Gebai <mohamad.gebai@polymtl.ca>,
alex.bennee@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 0/5] Fix UST backend for LTTng 2.x
Date: Tue, 14 Jan 2014 21:35:27 +0800 [thread overview]
Message-ID: <20140114133527.GC2995@stefanha-thinkpad> (raw)
In-Reply-To: <1382661967-23561-1-git-send-email-mohamad.gebai@polymtl.ca>
On Thu, Oct 24, 2013 at 08:46:02PM -0400, Mohamad Gebai wrote:
> Version 5
>
> * Use pkg-config for lttng-ust and urcu-bp libraries in configure (hard-coded
> libraries as a fallback)
> * s/Qemu/QEMU in docs/tracing.txt
> * Better dependencies for ust-generated files in trace/Makefile.obj
>
> Mohamad Gebai (5):
> Fix configure script for LTTng 2.x
> Modified the tracetool framework for LTTng 2.x
> Adapt Makefiles to the new LTTng ust interface
> Update documentation for LTTng ust tracing
> Add ust generated files to .gitignore
>
> .gitignore | 2 +
> Makefile | 5 ++
> configure | 20 ++++++--
> docs/tracing.txt | 36 ++++++++++++++
> scripts/tracetool/backend/events.py | 44 +++++++++++++++++
> scripts/tracetool/backend/ust.py | 82 +++++++-------------------------
> scripts/tracetool/format/ust_events_c.py | 30 ++++++++++++
> scripts/tracetool/format/ust_events_h.py | 57 ++++++++++++++++++++++
> trace/Makefile.objs | 25 ++++++++++
> 9 files changed, 230 insertions(+), 71 deletions(-)
> create mode 100644 scripts/tracetool/format/ust_events_c.py
> create mode 100644 scripts/tracetool/format/ust_events_h.py
Sorry for taking so long to review this. I have tested it successfully
on Fedora 20. Just a few comments on the patches but looking good.
prev parent reply other threads:[~2014-01-14 13:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 0:46 [Qemu-devel] [PATCH v5 0/5] Fix UST backend for LTTng 2.x Mohamad Gebai
2013-10-25 0:46 ` [Qemu-devel] [PATCH v5 1/5] Fix configure script " Mohamad Gebai
2013-10-25 13:18 ` Alex Bennée
2013-10-25 13:50 ` Mohamad Gebai
2013-10-25 14:33 ` Alex Bennée
2013-10-25 16:22 ` Mohamad Gebai
2014-01-14 13:34 ` Stefan Hajnoczi
2013-10-25 0:46 ` [Qemu-devel] [PATCH v5 2/5] Modified the tracetool framework " Mohamad Gebai
2014-01-14 13:33 ` Stefan Hajnoczi
2013-10-25 0:46 ` [Qemu-devel] [PATCH v5 3/5] Adapt Makefiles to the new LTTng ust interface Mohamad Gebai
2013-10-25 0:46 ` [Qemu-devel] [PATCH v5 4/5] Update documentation for LTTng ust tracing Mohamad Gebai
2013-10-25 11:23 ` Alex Bennée
2013-10-25 0:46 ` [Qemu-devel] [PATCH v5 5/5] Add ust generated files to .gitignore Mohamad Gebai
2013-11-04 16:41 ` [Qemu-devel] [PATCH v5 0/5] Fix UST backend for LTTng 2.x Alex Bennée
2013-12-11 1:45 ` Mohamad Gebai
2014-01-14 13:35 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114133527.GC2995@stefanha-thinkpad \
--to=stefanha@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=mohamad.gebai@gmail.com \
--cc=mohamad.gebai@polymtl.ca \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).