From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53065)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W349a-0001ty-44
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 08:35:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W349U-0002rL-OI
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 08:35:38 -0500
Received: from mail-pd0-x22d.google.com ([2607:f8b0:400e:c02::22d]:55845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1W349U-0002r5-E0
	for qemu-devel@nongnu.org; Tue, 14 Jan 2014 08:35:32 -0500
Received: by mail-pd0-f173.google.com with SMTP id p10so8805229pdj.4
	for <qemu-devel@nongnu.org>; Tue, 14 Jan 2014 05:35:31 -0800 (PST)
Date: Tue, 14 Jan 2014 21:35:27 +0800
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140114133527.GC2995@stefanha-thinkpad>
References: <1382661967-23561-1-git-send-email-mohamad.gebai@polymtl.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1382661967-23561-1-git-send-email-mohamad.gebai@polymtl.ca>
Subject: Re: [Qemu-devel] [PATCH v5 0/5] Fix UST backend for LTTng 2.x
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mohamad Gebai <mohamad.gebai@gmail.com>
Cc: Mohamad Gebai <mohamad.gebai@polymtl.ca>, alex.bennee@linaro.org, qemu-devel@nongnu.org

On Thu, Oct 24, 2013 at 08:46:02PM -0400, Mohamad Gebai wrote:
> Version 5
> 
> * Use pkg-config for lttng-ust and urcu-bp libraries in configure (hard-coded
>   libraries as a fallback)
> * s/Qemu/QEMU in docs/tracing.txt
> * Better dependencies for ust-generated files in trace/Makefile.obj
> 
> Mohamad Gebai (5):
>   Fix configure script for LTTng 2.x
>   Modified the tracetool framework for LTTng 2.x
>   Adapt Makefiles to the new LTTng ust interface
>   Update documentation for LTTng ust tracing
>   Add ust generated files to .gitignore
> 
>  .gitignore                               |  2 +
>  Makefile                                 |  5 ++
>  configure                                | 20 ++++++--
>  docs/tracing.txt                         | 36 ++++++++++++++
>  scripts/tracetool/backend/events.py      | 44 +++++++++++++++++
>  scripts/tracetool/backend/ust.py         | 82 +++++++-------------------------
>  scripts/tracetool/format/ust_events_c.py | 30 ++++++++++++
>  scripts/tracetool/format/ust_events_h.py | 57 ++++++++++++++++++++++
>  trace/Makefile.objs                      | 25 ++++++++++
>  9 files changed, 230 insertions(+), 71 deletions(-)
>  create mode 100644 scripts/tracetool/format/ust_events_c.py
>  create mode 100644 scripts/tracetool/format/ust_events_h.py

Sorry for taking so long to review this.  I have tested it successfully
on Fedora 20.  Just a few comments on the patches but looking good.