From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] trace: [simple] Do not include "trace/simple.h" in generated tracer headers
Date: Tue, 14 Jan 2014 21:36:57 +0800 [thread overview]
Message-ID: <20140114133657.GD2995@stefanha-thinkpad> (raw)
In-Reply-To: <20140109144123.21800.45879.stgit@fimbulvetr.bsc.es>
On Thu, Jan 09, 2014 at 03:41:23PM +0100, Lluís Vilanova wrote:
> diff --git a/trace/simple.c b/trace/simple.c
> index 1e3f691..8b59760 100644
> --- a/trace/simple.c
> +++ b/trace/simple.c
> @@ -8,6 +8,8 @@
> *
> */
>
> +#include "trace/simple.h"
> +
> #include <stdlib.h>
> #include <stdint.h>
> #include <stdio.h>
Please put user-defined header #includes (<>) below system header
#includes (""). This ensures we don't define macros that affect system
headers.
prev parent reply other threads:[~2014-01-14 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 14:41 [Qemu-devel] [PATCH] trace: [simple] Do not include "trace/simple.h" in generated tracer headers Lluís Vilanova
2014-01-14 13:36 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114133657.GD2995@stefanha-thinkpad \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).